Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 574433004: Revert of Fix lsan failure with ManifestParserTest.* (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix lsan failure with ManifestParserTest.* (patchset #1 id:1 of https://codereview.chromium.org/554043004/) Reason for revert: broke build Original issue's description: > Fix lsan failure with ManifestParserTest.* > > BUG=None > TBR=rockot@chromium.org > NOTRY=true > NOPRESUBMIT=true > > Committed: https://crrev.com/36816846f1cf8ceea2f96d501ebc745c82349337 > Cr-Commit-Position: refs/heads/master@{#294870} TBR=rockot@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/28e371d524b432b52b1c6ea71bdcd29705443147 Cr-Commit-Position: refs/heads/master@{#294876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/manifest/manifest_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mlamouri (slow - plz ping)
Created Revert of Fix lsan failure with ManifestParserTest.*
6 years, 3 months ago (2014-09-15 20:00:48 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-15 20:04:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574433004/1
6 years, 3 months ago (2014-09-15 20:07:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 16cdfcb8e24c433251d0e0c665bf178fb5032d2f
6 years, 3 months ago (2014-09-15 20:09:47 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 20:11:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28e371d524b432b52b1c6ea71bdcd29705443147
Cr-Commit-Position: refs/heads/master@{#294876}

Powered by Google App Engine
This is Rietveld 408576698