Issue 574413003: Revert "Suppress findbugs in CleanupReference."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 574413003: Revert "Suppress findbugs in CleanupReference." (Closed)

Created:
6 years, 3 months ago by Dirk Pranke

Modified:
6 years, 3 months ago

Reviewers:
aurimas

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert "Suppress findbugs in CleanupReference." This reverts commit 19ba619a29f4f757182bb4949e3b3d91bf4c1731. This CL caused the findbugs step to fail on Android Builder (dbg). TBR=aurimas@google.com BUG=411131 > commit 19ba619a29f4f757182bb4949e3b3d91bf4c1731 > Author: Aurimas Liutikas <aurimas@google.com>; > Date: Wed Sep 17 13:12:06 2014 -0700 > > Suppress findbugs in CleanupReference. > > BUG=411131 > TBR=dtrainor@chromium.org > > Review URL: > https://codereview.chromium.org/573693004 > > Cr-Commit-Position: refs/heads/master@{#295331} Committed: https://crrev.com/170d8dac15cdf62c1bf9fd8c314ec68c3cb4bda2 Cr-Commit-Position: refs/heads/master@{#295339}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	build/android/findbugs_filter/findbugs_known_bugs.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Dirk Pranke

Build failure: https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20(dbg)/builds/65946

6 years, 3 months ago (2014-09-17 20:40:04 UTC) #1

Dirk Pranke

Committed patchset #1 (id:1) manually as 170d8da (presubmit successful).

6 years, 3 months ago (2014-09-17 20:41:48 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-17 20:41:50 UTC) #3

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/170d8dac15cdf62c1bf9fd8c314ec68c3cb4bda2
Cr-Commit-Position: refs/heads/master@{#295339}