Add Vary support for ServiceWorkerCache::Match.

Add Vary support for ServiceWorkerCache::Match.

Simple vary implementation and tests.

Downstream of https://codereview.chromium.org/576973004/

BUG=392621
Committed: https://crrev.com/102e7d430e7ef66dd840b0cbef76ff9a81e0ac84
Cr-Commit-Position: refs/heads/master@{#296393}

[jkarlin, 2014-09-17 18:48:10]

https://codereview.chromium.org/574393002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/574393002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:382: // ASSERTS in
WebServiceWorkerRequest and WebServiceWorkerResponse.
The ASSERTS this comment speaks of are in review:

https://codereview.chromium.org/564773004/ and
https://codereview.chromium.org/578763003/

[jkarlin, 2014-09-17 18:48:21]

jkarlin@chromium.org changed reviewers:
+ michaeln@chromium.org

[jkarlin, 2014-09-17 18:48:22]

Thanks!

[jkarlin, 2014-09-18 18:01:27]

PTAL, thanks!

[jsbell, 2014-09-22 19:17:31]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2014-09-22 19:17:32]

lgtm, FWIW.

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:377: const
ServiceWorkerHeaderMap& response) {
(I'm assuming we lowercase all the header names somewhere...)

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:384: for (size_t i = 0,
max = vary_keys.size(); i < max; ++i) {
Why is this an index/size loop instead of an iterator?

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:439:
cached_request_headers.insert(
Shorter to write: cached_request_headers[header.name()] = header.value();

[jsbell, 2014-09-22 19:18:18]

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:377: const
ServiceWorkerHeaderMap& response) {
On 2014/09/22 19:17:32, jsbell wrote:
> (I'm assuming we lowercase all the header names somewhere...)

... and that'd be https://codereview.chromium.org/576973004/ which I was going
to look at next. :)

[jkarlin, 2014-09-23 11:42:51]

Thanks!

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:377: const
ServiceWorkerHeaderMap& response) {
On 2014/09/22 19:17:32, jsbell wrote:
> (I'm assuming we lowercase all the header names somewhere...)

Acknowledged.

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:384: for (size_t i = 0,
max = vary_keys.size(); i < max; ++i) {
On 2014/09/22 19:17:32, jsbell wrote:
> Why is this an index/size loop instead of an iterator?

Done.

https://codereview.chromium.org/574393002/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:439:
cached_request_headers.insert(
On 2014/09/22 19:17:32, jsbell wrote:
> Shorter to write: cached_request_headers[header.name()] = header.value();

Done.

[jkarlin, 2014-09-23 13:12:05]

jkarlin@chromium.org changed reviewers:
+ horo@chromium.org

[jkarlin, 2014-09-23 13:12:25]

horo: Please look for serviceworker owners.  Thanks!

[jkarlin, 2014-09-23 13:12:48]

On 2014/09/23 13:12:25, jkarlin wrote:
> horo: Please look for serviceworker owners.  Thanks!

Er, please review for serviceworker ownership.  Thanks.

[jkarlin, 2014-09-23 13:12:52]

On 2014/09/23 13:12:25, jkarlin wrote:
> horo: Please look for serviceworker owners.  Thanks!

Er, please review for serviceworker ownership.  Thanks.

[horo, 2014-09-24 02:11:20]

lgtm

[jkarlin, 2014-09-24 12:16:38]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-24 12:16:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/574393002/100001

[commit-bot: I haz the power, 2014-09-24 12:41:00]

Committed patchset #6 (id:100001) as eb77295c23bd0bf4ba9e0f617c6d128eff63b3c1

[commit-bot: I haz the power, 2014-09-24 12:41:40]

Patchset 6 (id:??) landed as
https://crrev.com/102e7d430e7ef66dd840b0cbef76ff9a81e0ac84
Cr-Commit-Position: refs/heads/master@{#296393}