Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 574383002: declare to gypi where SkDeviceProperties.h moved to (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
tfarina
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

declare to gypi where SkDeviceProperties.h moved to NOTRY=True NOTREECHECKS=True TBR= Committed: https://skia.googlesource.com/skia/+/85265ffebe78982589ed85457ae1cefba5d4355d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M gyp/core.gypi View 2 chunks +1 line, -1 line 1 comment Download
M gyp/public_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574383002/1
6 years, 3 months ago (2014-09-17 17:58:47 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-17 17:58:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574383002/1
6 years, 3 months ago (2014-09-17 17:59:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 85265ffebe78982589ed85457ae1cefba5d4355d
6 years, 3 months ago (2014-09-17 17:59:27 UTC) #7
tfarina
6 years, 3 months ago (2014-09-17 18:02:12 UTC) #9
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/574383002/diff/1/gyp/core.gypi
File gyp/core.gypi (right):

https://codereview.chromium.org/574383002/diff/1/gyp/core.gypi#newcode70
gyp/core.gypi:70: '<(skia_src_path)/core/SkDeviceProperties.h',
correct,
https://skia.googlesource.com/skia/+/master/src/core/SkDeviceProperties.h

Powered by Google App Engine
This is Rietveld 408576698