Roll Skia DEPS to r12124

Roll Skia DEPS to r12124

R=rmistry@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232963

[robertphillips, 2013-11-05 02:20:32]

control: https://codereview.chromium.org/57433014/

[robertphillips, 2013-11-05 12:47:54]

This roll attempt is failing on the following 79 layout tests:

Regressions: Unexpected image-only failures (79)
  css3/filters/blur-filter-page-scroll-parents.html [ ImageOnlyFailure ]
  css3/filters/blur-filter-page-scroll-self.html [ ImageOnlyFailure ]
  css3/filters/blur-filter-page-scroll.html [ ImageOnlyFailure ]
  css3/filters/crash-filter-change.html [ ImageOnlyFailure ]
  css3/filters/effect-blur.html [ ImageOnlyFailure ]
  css3/filters/effect-brightness-clamping.html [ ImageOnlyFailure ]
  css3/filters/effect-combined.html [ ImageOnlyFailure ]
  css3/filters/effect-drop-shadow.html [ ImageOnlyFailure ]
  css3/filters/effect-reference-colorspace.html [ ImageOnlyFailure ]
  css3/filters/effect-reference-hidpi.html [ ImageOnlyFailure ]
  css3/filters/effect-reference-ordering.html [ ImageOnlyFailure ]
  css3/filters/effect-reference-subregion.html [ ImageOnlyFailure ]
  css3/filters/effect-reference-zoom.html [ ImageOnlyFailure ]
  css3/filters/effect-reference.html [ ImageOnlyFailure ]
  css3/filters/filter-change-repaint.html [ ImageOnlyFailure ]
  css3/filters/filter-repaint-blur.html [ ImageOnlyFailure ]
  css3/filters/filter-repaint-child-layers.html [ ImageOnlyFailure ]
  css3/filters/filter-repaint-shadow.html [ ImageOnlyFailure ]
  css3/filters/filter-repaint.html [ ImageOnlyFailure ]
  css3/filters/filtered-inline.html [ ImageOnlyFailure ]
  css3/filters/regions-expanding.html [ ImageOnlyFailure ]
  css3/masking/clip-path-circle-filter.html [ ImageOnlyFailure ]
  svg/W3C-SVG-1.1/filters-example-01-b.svg [ ImageOnlyFailure ]
  svg/W3C-SVG-1.1/filters-gauss-01-b.svg [ ImageOnlyFailure ]
  svg/batik/text/smallFonts.svg [ ImageOnlyFailure ]
  svg/batik/text/textEffect.svg [ ImageOnlyFailure ]
  svg/batik/text/textEffect3.svg [ ImageOnlyFailure ]
  svg/batik/text/textFeatures.svg [ ImageOnlyFailure ]
  svg/batik/text/textProperties.svg [ ImageOnlyFailure ]
  svg/css/path-gradient-stroke-shadow.svg [ ImageOnlyFailure ]
  svg/css/rect-gradient-stroke-shadow.svg [ ImageOnlyFailure ]
  svg/custom/image-with-transform-clip-filter.svg [ ImageOnlyFailure ]
  svg/custom/recursive-filter.svg [ ImageOnlyFailure ]
  svg/custom/resource-invalidate-on-target-update.svg [ ImageOnlyFailure ]
  svg/custom/text-filter.svg [ ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr.html
[ ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr.html [
ImageOnlyFailure ]
 
svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
[ ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop.html [
ImageOnlyFailure ]
 
svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop.html
[ ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop.html
[ ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html [ ImageOnlyFailure
]
  svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html [ ImageOnlyFailure
]
  svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html [ ImageOnlyFailure
]
  svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr.html [ ImageOnlyFailure
]
  svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr.html [ ImageOnlyFailure
]
  svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr.html [ ImageOnlyFailure
]
  svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop.html [
ImageOnlyFailure ]
  svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop.html [
ImageOnlyFailure ]
  svg/filters/feDropShadow-zero-deviation.svg [ ImageOnlyFailure ]
  svg/filters/feDropShadow.svg [ ImageOnlyFailure ]
  svg/filters/feGaussianBlur-zero-deviation.svg [ ImageOnlyFailure ]
  svg/filters/feGaussianBlur.svg [ ImageOnlyFailure ]
  svg/filters/filter-clip.svg [ ImageOnlyFailure ]
  svg/filters/filter-on-filter-for-text.svg [ ImageOnlyFailure ]
  svg/filters/filter-width-update.svg [ ImageOnlyFailure ]
  svg/filters/filterRes.svg [ ImageOnlyFailure ]
  svg/filters/invalidate-on-child-layout.svg [ ImageOnlyFailure ]
  svg/filters/shadow-on-filter.svg [ ImageOnlyFailure ]
  svg/repaint/filter-child-repaint.svg [ ImageOnlyFailure ]
  virtual/softwarecompositing/culling/filter-occlusion-blur-large.html [
ImageOnlyFailure ]
  virtual/softwarecompositing/culling/filter-occlusion-blur.html [
ImageOnlyFailure ]

Note that the following 2 layout tests are not failing on Mac:

virtual/softwarecompositing/culling/filter-occlusion-blur-large.html [
ImageOnlyFailure ]
virtual/softwarecompositing/culling/filter-occlusion-blur.html [
ImageOnlyFailure ]

The discrepancies between the roll and control are:

android_dbg
   roll:    
            slave_steps
                preamble
            zip_build 
   control: 
            lost bot

linux
   roll:    
            buildrunner_tests
                preamble
            check_deps 
   control: 
            gclient_revert failed
            update r232882 failed

mac
   roll:    
            buildrunner_tests
                preamble
            telemetry_perf_unittests failed 2
                testCacheHandled
                testCalcResultsTraceEvents
   control: 
            still running?

win
   roll:    
            buildrunner_tests
                preamble
            telemetry_perf_unittests failed 2 
                testCacheHandled
                testCalcResultsTraceEvents
            content_unittests failed 1 
                SingleGesture
            content_browsertests did not complete failed 6 
                SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc ***************
                ResumeInterruptedDownloadBadPrecondition *********************
                AccessibilityAOnclick ****************************************
                TestGetUserMediaConstraints **********************************
                LimitTotal
                WebSocketSharedWorker
   control: 
            buildrunner_tests 
                preamble
            telemetry_perf_unittests failed 2 
                testCacheHandled
                testCalcResultsTraceEvents
            content_unittests failed 2 
                SingleGesture
                TestValidInputRates
            content_browsertests did not complete failed 5 
                GetAudioAndVideoStreamAndClone
                GetAudioAndVideoStreamAndStop
                GetVideoStreamAndStop
                LimitTotal
                WebSocketSharedWorker

linux_layout
   roll:    
            webkit_tests 213 fixable (0 skipped) failed 79
                ...
   control: 
            green

linux_layout_rel
   roll:    
            webkit_tests 189 fixable (0 skipped) failed 79
                ...
   control: 
            green

mac_layout
   roll:    
            webkit_tests 763 fixable (0 skipped) failed 77
                ...
   control: 
            green

mac_layout_rel
   roll:    
            webkit_tests 749 fixable (0 skipped) failed 77
                ...
   control: 
            green

win_layout
   roll:    
            webkit_tests 287 fixable (0 skipped) failed 79
                ...
   control: 
            green

win_layout_rel
   roll:    
            webkit_tests 249 fixable (0 skipped) failed 79
                ...
   control: 
            green

[robertphillips, 2013-11-05 13:07:03]

The majority of these changes are what you would expect from r12113 (Change
SkBlurImageFilter to use fixed-point division
https://codereview.chromium.org/57513002) i.e., imperceptible blur changes. The
following four image differences are perceptible however:

svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html
svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html
svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html

and the blurred area has shrunk in all of them.

[robertphillips, 2013-11-05 13:44:46]

Added the suppression to skia_library.gypi & reran the bots. This looks ready to
go.

[rmistry, 2013-11-05 13:46:25]

LGTM

[robertphillips, 2013-11-05 13:47:10]

Committed patchset #2 manually as r232963 (presubmit successful).

[reed1, 2013-11-05 16:00:15]

Does the new impl of blur maintain opaqueness? i.e. if all the sample values are
0xFF, is the result 0xFF? Couldn't tell if we need to add anything in the code
before shifting to ensure this.