Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 57433011: Restructure the events target into two components: (Closed)

Created:
7 years, 1 month ago by Ben Goodger (Google)
Modified:
7 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, ben+aura_chromium.org, amit, sievers+watch_chromium.org, sadrul, dcaiafa+watch_chromium.org, jam, alexeypa+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, kalyank, wez+watch_chromium.org, sanjeevr, feature-media-reviews_chromium.org, jbauman+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org, cc-bugs_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Ian Vollick, tfarina, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Restructure the events target into two components: - events_base (built by most people) - defining some basic utilities. - events (built by users of aura/views) - the ui::Event type & friends. Prior to this there was one target, and platforms that did not want ui::Event would exclude those files explicitly, making it hard to build those files on those platforms without breaking other components. R=sadrul@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233347

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : stubs #

Patch Set 5 : mac, android #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -120 lines) Patch
M cc/cc.gyp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 4 chunks +1 line, -4 lines 0 comments Download
M components/autofill.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M content/content_app.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 6 7 8 4 chunks +3 lines, -5 lines 0 comments Download
M ui/compositor/compositor.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/events/event_switches.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ui/events/events.gyp View 2 3 4 chunks +36 lines, -38 lines 0 comments Download
A ui/events/events_base_export.h View 1 6 7 1 chunk +29 lines, -0 lines 0 comments Download
A ui/events/events_stub.cc View 1 2 3 4 5 6 1 chunk +151 lines, -0 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_gtk.h View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_mac.h View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_x.h View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/events/latency_info.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 4 chunks +1 line, -3 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/snapshot/snapshot.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/surface/surface.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ui.gyp View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/ui_unittests.gyp View 1 2 3 4 5 4 chunks +7 lines, -3 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
7 years, 1 month ago (2013-11-05 00:14:51 UTC) #1
sadrul
lgtm (You may need to put back some of the dependencies on events you are ...
7 years, 1 month ago (2013-11-05 03:29:19 UTC) #2
Ben Goodger (Google)
7 years, 1 month ago (2013-11-06 20:38:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #9 manually as r233347 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698