Prevent creating a swapped out RVH in the same SiteInstance as the current one.

chrome/browser/extensions/api/management/management_api_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/management/management_api.h"
 #include "chrome/browser/extensions/api/management/management_api_constants.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/common/url_constants.h"
+#include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 
 namespace keys = extension_management_api_constants;
 namespace util = extension_function_test_utils;
 
 namespace extensions {
 
 class ExtensionManagementApiBrowserTest : public ExtensionBrowserTest {
  protected:
   bool CrashEnabledExtension(const std::string& extension_id) {
-    content::WindowedNotificationObserver extension_crash_observer(
-        chrome::NOTIFICATION_EXTENSION_PROCESS_TERMINATED,
-        content::NotificationService::AllSources());
     ExtensionHost* background_host =
         ExtensionSystem::Get(browser()->profile())->
             process_manager()->GetBackgroundHostForExtension(extension_id);
     if (!background_host)
       return false;
-    background_host->host_contents()->GetController().LoadURL(
-        GURL(content::kChromeUICrashURL), content::Referrer(),
-        content::PAGE_TRANSITION_LINK, std::string());
-    extension_crash_observer.Wait();
+    content::CrashTab(background_host->host_contents());
     return true;
   }
 };
 
 // We test this here instead of in an ExtensionApiTest because normal extensions
 // are not allowed to call the install function.
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiBrowserTest, InstallEvent) {
   ExtensionTestMessageListener listener1("ready", false);
   ASSERT_TRUE(LoadExtension(
       test_data_dir_.AppendASCII("management/install_event")));
@@ skipping 194 matching lines @@
   ASSERT_TRUE(result->IsType(base::Value::TYPE_DICTIONARY));
   base::DictionaryValue* dict =
       static_cast<base::DictionaryValue*>(result.get());
   std::string reason;
   EXPECT_TRUE(dict->GetStringASCII(keys::kDisabledReasonKey, &reason));
   EXPECT_EQ(reason, std::string(keys::kDisabledReasonPermissionsIncrease));
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiEscalationTest,
                        SetEnabled) {
+  LOG(INFO) << "SetEnabled: start of test.";
   // Expect an error about no gesture.
   SetEnabled(true, false, keys::kGestureNeededForEscalationError);
+  LOG(INFO) << "SetEnabled: setenabled with gesture error.";

[ncarter (slow), 2013/11/12 03:38:26]

Don't forget to remove these LOG(INFO)s

[Charlie Reis, 2013/11/12 16:09:35]

Done.

 
   // Expect an error that user cancelled the dialog.
   CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kAppsGalleryInstallAutoConfirmForTests, "cancel");
   SetEnabled(true, true, keys::kUserDidNotReEnableError);
+  LOG(INFO) << "SetEnabled: setenabled with user cancel error.";
 
-  // This should succeed when user accepts dialog.
+  // This should succeed when user accepts dialog.  We must wait for the process
+  // to connect before trying to crash it.
+  content::WindowedNotificationObserver observer(
+      content::NOTIFICATION_RENDERER_PROCESS_CREATED,

[ncarter (slow), 2013/11/12 03:38:26]

Change this to chrome::NOTIFICATION_EXTENSION_HOST_CREATED to make sure that the
channel finishes establishing itself. Otherwise, it seems on Windows we kill the
process before such a point where we'd notice a broken pipe and trigger the
RENDERER_PROCESS_CLOSED notification that CrashTab is expecting.

[Charlie Reis, 2013/11/12 16:09:35]

Done.

+      content::NotificationService::AllSources());
   CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kAppsGalleryInstallAutoConfirmForTests, "accept");
   SetEnabled(true, true, std::string());
+  LOG(INFO) << "SetEnabled: setenabled success.";
+  observer.Wait();
+  LOG(INFO) << "SetEnabled: process created.";
 
   // Crash the extension. Mock a reload by disabling and then enabling. The
   // extension should be reloaded and enabled.
   ASSERT_TRUE(CrashEnabledExtension(kId));
+  LOG(INFO) << "SetEnabled: extension process crashed.";
   SetEnabled(false, true, std::string());
+  LOG(INFO) << "SetEnabled: disabled.";
   SetEnabled(true, true, std::string());
+  LOG(INFO) << "SetEnabled: enabled.";
   const Extension* extension = ExtensionSystem::Get(browser()->profile())
       ->extension_service()->GetExtensionById(kId, false);
   EXPECT_TRUE(extension);
+  LOG(INFO) << "SetEnabled: done.";
 }
 
 }  // namespace extensions