Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 57433003: Add missing negative dictionary lookup to NonexistentHandlerFrontend (Closed)

Created:
7 years, 1 month ago by Jakob Kummerow
Modified:
7 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Add missing negative dictionary lookup to NonexistentHandlerFrontend BUG=v8:2980 R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17459

Patch Set 1 #

Patch Set 2 : also upload test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -216 lines) Patch
M src/arm/stub-cache-arm.cc View 4 chunks +18 lines, -44 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 5 chunks +23 lines, -49 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 4 chunks +18 lines, -47 lines 0 comments Download
M src/stub-cache.h View 2 chunks +30 lines, -0 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 5 chunks +26 lines, -55 lines 0 comments Download
A + test/mjsunit/regress/regress-2980.js View 1 1 chunk +30 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
Got tired of copy-pasting the same patch to all architectures, so I took the opportunity ...
7 years, 1 month ago (2013-11-04 14:05:31 UTC) #1
Toon Verwaest
lgtm if you add the test case
7 years, 1 month ago (2013-11-04 14:08:30 UTC) #2
Jakob Kummerow
Thanks, landing.
7 years, 1 month ago (2013-11-04 14:12:50 UTC) #3
Jakob Kummerow
7 years, 1 month ago (2013-11-04 14:14:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17459.

Powered by Google App Engine
This is Rietveld 408576698