Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

Issue 574293002: Files.app: Show thumbnail of non-image file even when the file cache is present (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix null-pointer exception Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
index 2b1b9c3301c9f888e3f08e85c858f707bf7277e2..18026a84acf39e8ec7eae07d95f5019d1afea960 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
@@ -76,10 +76,7 @@ void FillEntryPropertiesValueForDrive(const drive::ResourceEntry& entry_proto,
const drive::FileSpecificInfo& file_specific_info =
entry_proto.file_specific_info();
- // The web thumbnail is used only when the file is not present. Otherwise
- // it could be out of sync.
- if (!entry_proto.resource_id().empty() &&
- !file_specific_info.cache_state().is_present()) {
+ if (!entry_proto.resource_id().empty()) {
properties->thumbnail_url.reset(
mtomasz 2014/09/17 09:29:48 AFAIR, the check for is_present() was done by @hir
yoshiki 2014/09/17 09:57:09 The generated thumbnail has higher priority and th
new std::string("https://www.googledrive.com/thumb/" +
entry_proto.resource_id() + "?width=500&height=500"));

Powered by Google App Engine
This is Rietveld 408576698