Issue 574283004: Fix shared libary build for content_browsertests.

Issue 574283004: Fix shared libary build for content_browsertests. (Closed)

Created:
6 years, 3 months ago by elecro

Modified:
6 years, 3 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr, mkwst+moarreviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Fix shared libary build for content_browsertests. Move the WebMIDIClientMock destructor implementation from the header to the cpp. This way we can avoid undefined vtable errors. BUG=415162 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182326

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	Source/web/WebMIDIClientMock.cpp	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
	M	public/web/WebMIDIClientMock.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 8 (2 generated)

jochen (gone - plz use gerrit)

when you move the dtor, you don't need the reset() method anymore, no?

6 years, 3 months ago (2014-09-17 19:10:29 UTC) #3

elecro

On 2014/09/17 19:10:29, jochen wrote: > when you move the dtor, you don't need the ...

6 years, 3 months ago (2014-09-18 08:27:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574283004/20001

6 years, 3 months ago (2014-09-19 12:16:43 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 13:42:02 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 182326