Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574283002: [Win] Convert min|max window size to screen pixels. (Closed)

Created:
6 years, 3 months ago by jackhou1
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Win] Convert min|max window size to screen pixels. BUG=413294 Committed: https://crrev.com/336bb31397644875fefbb84d6fa4ce799a021ec0 Cr-Commit-Position: refs/heads/master@{#295613}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move DIP-pixel conversion to hwnd_message_handler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jackhou1
sky, could you please review this?
6 years, 3 months ago (2014-09-17 06:59:41 UTC) #2
sky
https://codereview.chromium.org/574283002/diff/1/ui/views/win/hwnd_message_handler_delegate.h File ui/views/win/hwnd_message_handler_delegate.h (right): https://codereview.chromium.org/574283002/diff/1/ui/views/win/hwnd_message_handler_delegate.h#newcode67 ui/views/win/hwnd_message_handler_delegate.h:67: // user. Units are screen pixels. The hope is ...
6 years, 3 months ago (2014-09-17 15:44:26 UTC) #3
jackhou1
https://codereview.chromium.org/574283002/diff/1/ui/views/win/hwnd_message_handler_delegate.h File ui/views/win/hwnd_message_handler_delegate.h (right): https://codereview.chromium.org/574283002/diff/1/ui/views/win/hwnd_message_handler_delegate.h#newcode67 ui/views/win/hwnd_message_handler_delegate.h:67: // user. Units are screen pixels. On 2014/09/17 15:44:26, ...
6 years, 3 months ago (2014-09-18 03:36:42 UTC) #4
sky
LGTM
6 years, 3 months ago (2014-09-18 13:05:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/574283002/20001
6 years, 3 months ago (2014-09-18 23:16:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7d5898599c15fb0b886ab40bc84aefa840165728
6 years, 3 months ago (2014-09-18 23:59:46 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 00:00:26 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/336bb31397644875fefbb84d6fa4ce799a021ec0
Cr-Commit-Position: refs/heads/master@{#295613}

Powered by Google App Engine
This is Rietveld 408576698