Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 574273003: Remove Notification::small_image_url_ as it has no users. (Closed)

Created:
6 years, 3 months ago by Peter Beverloo
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai, dewittj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Notification::small_image_url_ as it has no users. Also removes two methods from Notification which only forward calls to the delegate, and have a single call-site. BUG= Committed: https://crrev.com/4542ea08cfd1c978f8e3ec27d797e0945aba0cf1 Cr-Commit-Position: refs/heads/master@{#295499}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/browser/notifications/message_center_notification_manager.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/notification.h View 1 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Beverloo
Very small clean-up patch, but trimming down Notification as far as we can is a ...
6 years, 3 months ago (2014-09-18 13:54:55 UTC) #2
Jun Mukai
lgtm
6 years, 3 months ago (2014-09-18 17:40:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/574273003/40001
6 years, 3 months ago (2014-09-18 17:42:46 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 670c44358ccb68bdf7e1fdcd1d1d52c79f5c7acd
6 years, 3 months ago (2014-09-18 18:18:51 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:19:27 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4542ea08cfd1c978f8e3ec27d797e0945aba0cf1
Cr-Commit-Position: refs/heads/master@{#295499}

Powered by Google App Engine
This is Rietveld 408576698