Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: media/blink/buffered_data_source.h

Issue 574253002: Enhance WebMediaPlayer::buffered() to account for evicted ranges. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/buffered_data_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/buffered_data_source.h
diff --git a/media/blink/buffered_data_source.h b/media/blink/buffered_data_source.h
index 5ae7d935c622931f27fff2682aadb30f8e182565..f0dbcc298ff29fb4ef93fe0fb0871aa311cb7be3 100644
--- a/media/blink/buffered_data_source.h
+++ b/media/blink/buffered_data_source.h
@@ -29,10 +29,11 @@ class MEDIA_EXPORT BufferedDataSourceHost {
virtual void SetTotalBytes(int64 total_bytes) = 0;
// Notify the host that byte range [start,end] has been buffered.
- // TODO(fischman): remove this method when demuxing is push-based instead of
- // pull-based. http://crbug.com/131444
scherkus (not reviewing) 2014/09/17 16:25:28 while http://crbug.com/131444 has been closed as W
virtual void AddBufferedByteRange(int64 start, int64 end) = 0;
+ // Notify the host that byte range [0, end) has been evicted.
+ virtual void RemoveBufferedByteRange(int64 end) = 0;
+
protected:
virtual ~BufferedDataSourceHost() {};
};
@@ -152,7 +153,7 @@ class MEDIA_EXPORT BufferedDataSource : public DataSource {
// BufferedResourceLoader callbacks.
void ReadCallback(BufferedResourceLoader::Status status, int bytes_read);
void LoadingStateChangedCallback(BufferedResourceLoader::LoadingState state);
- void ProgressCallback(int64 position);
+ void ProgressCallback(int64 earliest_position, int64 position);
// Update |loader_|'s deferring strategy in response to a play/pause, or
// change in playback rate.
« no previous file with comments | « no previous file | media/blink/buffered_data_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698