Base: Make RegistryOverrideManager support sharded/parallel tests.

base/test/test_reg_util_win.cc

Index: base/test/test_reg_util_win.cc
diff --git a/base/test/test_reg_util_win.cc b/base/test/test_reg_util_win.cc
index e23c6e9b27a54797525f73194cf7afc49e00bf99..aeec013a1ece74f6cd7b7b7b07c15c6561f4b33b 100644
--- a/base/test/test_reg_util_win.cc
+++ b/base/test/test_reg_util_win.cc
@@ -4,22 +4,51 @@
 
 #include "base/test/test_reg_util_win.h"
 
+#include "base/guid.h"
 #include "base/logging.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace registry_util {
 
+namespace {
+
+void DeleteStaleTestKeys(const base::Time& now, const string16& test_key_root) {
+  base::win::RegKey test_root_key;
+  if (ERROR_SUCCESS !=
+        test_root_key.Open(HKEY_CURRENT_USER, test_key_root.c_str(),
+                           KEY_ALL_ACCESS)) {
+    return;

[Paweł Hajdan Jr., 2013/11/06 20:33:58]

Since this can fail, let's return bool and add WARN_UNUSED_RESULT.

[tommycli, 2013/11/06 21:44:23]

This occurs on first-run, and is harmless. This should be ignored.

+  }
+
+  base::win::RegistryKeyIterator iterator_test_root_key(
+      HKEY_CURRENT_USER, test_key_root.c_str());
+  for (; iterator_test_root_key.Valid(); ++iterator_test_root_key) {
+    string16 key_name = iterator_test_root_key.Name();
+    int64 key_name_as_number = 0;
+    if (!base::StringToInt64(key_name, &key_name_as_number)) {
+      test_root_key.DeleteKey(key_name.c_str());
+      continue;
+    }
+
+    base::Time key_time = base::Time::FromInternalValue(key_name_as_number);
+    base::TimeDelta age = now - key_time;
+
+    if (age > base::TimeDelta::FromHours(1))

[Paweł Hajdan Jr., 2013/11/06 20:33:58]

Let's make this bigger: 24 hours.

[tommycli, 2013/11/06 21:44:23]

Done.

+      test_root_key.DeleteKey(key_name.c_str());
+  }
+}
+
+}

[Paweł Hajdan Jr., 2013/11/06 20:33:58]

nit:  // namespace

[tommycli, 2013/11/06 21:44:23]

Done.

+
 const wchar_t RegistryOverrideManager::kTempTestKeyPath[] =
     L"Software\\Chromium\\TempTestKeys";
 
 RegistryOverrideManager::ScopedRegistryKeyOverride::ScopedRegistryKeyOverride(
     HKEY override,
-    const std::wstring& temp_name)
-    : override_(override),
-      temp_name_(temp_name) {
-  DCHECK(!temp_name_.empty());
-  std::wstring key_path(RegistryOverrideManager::kTempTestKeyPath);
-  key_path += L"\\" + temp_name_;
+    const string16& key_path)
+    : override_(override) {
   EXPECT_EQ(ERROR_SUCCESS,
       temp_key_.Create(HKEY_CURRENT_USER, key_path.c_str(), KEY_ALL_ACCESS));
   EXPECT_EQ(ERROR_SUCCESS,
@@ -29,37 +58,35 @@ RegistryOverrideManager::ScopedRegistryKeyOverride::ScopedRegistryKeyOverride(
 RegistryOverrideManager::
     ScopedRegistryKeyOverride::~ScopedRegistryKeyOverride() {
   ::RegOverridePredefKey(override_, NULL);
-  // The temp key will be deleted via a call to DeleteAllTempKeys().
+  temp_key_.DeleteKey(L"");
 }
 
-RegistryOverrideManager::RegistryOverrideManager() {
-  DeleteAllTempKeys();
+RegistryOverrideManager::RegistryOverrideManager()
+    : timestamp_(base::Time::Now()),
+      guid_(base::ASCIIToWide(base::GenerateGUID())),
+      test_key_root_(kTempTestKeyPath) {
+  DeleteStaleTestKeys(timestamp_, test_key_root_);
 }
 
-RegistryOverrideManager::~RegistryOverrideManager() {
-  RemoveAllOverrides();
+RegistryOverrideManager::RegistryOverrideManager(const base::Time& timestamp,
+                                                 const string16& test_key_root)
+    : timestamp_(timestamp),
+      guid_(base::ASCIIToWide(base::GenerateGUID())),
+      test_key_root_(test_key_root) {
+  DeleteStaleTestKeys(timestamp_, test_key_root_);
 }
 
-void RegistryOverrideManager::OverrideRegistry(HKEY override,
-                                               const std::wstring& temp_name) {
-  overrides_.push_back(new ScopedRegistryKeyOverride(override, temp_name));
-}
 
-void RegistryOverrideManager::RemoveAllOverrides() {
-  while (!overrides_.empty()) {
-    delete overrides_.back();
-    overrides_.pop_back();
-  }
+RegistryOverrideManager::~RegistryOverrideManager() {}
 
-  DeleteAllTempKeys();
-}
+void RegistryOverrideManager::OverrideRegistry(HKEY override,
+                                               const string16& override_name) {
+  string16 key_path = test_key_root_;
+  key_path += L"\\" + base::Int64ToString16(timestamp_.ToInternalValue());
+  key_path += L"\\" + guid_;
+  key_path += L"\\" + override_name;
 
-// static
-void RegistryOverrideManager::DeleteAllTempKeys() {
-  base::win::RegKey key;
-  if (key.Open(HKEY_CURRENT_USER, L"", KEY_ALL_ACCESS) == ERROR_SUCCESS) {
-    key.DeleteKey(kTempTestKeyPath);
-  }
+  overrides_.push_back(new ScopedRegistryKeyOverride(override, key_path));
 }
 
 }  // namespace registry_util