Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 57423005: Switch to new main semantics (fixes issue 14797) (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, vsm, keertip
Visibility:
Public.

Description

Switch to new main semantics (fixes issue 14797) R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -56 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/webui/webapp.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/component/news/web/index.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/boot.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/script_compactor.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M pkg/polymer/test/build/all_phases_test.dart View 5 chunks +13 lines, -22 lines 0 comments Download
M pkg/polymer/test/build/script_compactor_test.dart View 2 chunks +6 lines, -9 lines 0 comments Download
M runtime/bin/vmservice/client/web/index.html View 1 chunk +1 line, -5 lines 0 comments Download
M samples/third_party/todomvc/web/index.html View 1 chunk +1 line, -1 line 0 comments Download
M samples/tracker/web/index.html View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
This change will need to be cherry pick to match the semantic changes in Dartium ...
7 years, 1 month ago (2013-11-04 22:02:57 UTC) #1
Cutch
vmservice change lgtm
7 years, 1 month ago (2013-11-04 22:04:06 UTC) #2
Jennifer Messerly
lgtm
7 years, 1 month ago (2013-11-04 22:14:16 UTC) #3
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-11-05 01:52:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698