runtime/vm/flow_graph_builder.cc - Issue 57423003: Restore 0-based temporary index numbering in the VM compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 57423003: Restore 0-based temporary index numbering in the VM compiler. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index 5970b44a6a90de1fcda9549f98dfb43b027ca11d..8e87e0aec6fecc42b5a36b8388a7bb41b285c4bd 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -1914,7 +1914,7 @@ LocalVariable* EffectGraphVisitor::EnterTempLocalScope(Value* value) {

Do(new PushTempInstr(value));

owner()->AllocateTemp();

- ASSERT(value->definition()->temp_index() == owner()->temp_count());

+ ASSERT(value->definition()->temp_index() == (owner()->temp_count() - 1));

intptr_t index = GetCurrentTempLocalIndex();

char name[64];

OS::SNPrint(name, 64, ":tmp_local%" Pd, index);

« no previous file with comments | « runtime/vm/flow_graph_builder.h ('k') | no next file » | no next file with comments »