extensions/common/manifest_handlers/file_handler_manifest_unittest.cc - Issue 574173002: Reland: Refactor ExtensionManifestTest to allow usage in src/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

Issue 574173002: Reland: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (manifest-test) add ScopedChannel Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/manifest_handlers/externally_connectable_unittest.cc ('k') | extensions/common/manifest_handlers/shared_module_manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

diff --git a/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc b/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

index 678dc6bcc7576d56e93d736dbb32886d99fc786e..f45d922d50e93b5d926e97744e019284bbb52b67 100644

--- a/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

+++ b/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

@@ -2,7 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

+#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

#include "extensions/common/manifest_constants.h"

#include "extensions/common/manifest_handlers/file_handler_info.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -11,7 +11,8 @@ namespace extensions {

namespace errors = manifest_errors;

-class FileHandlersManifestTest : public ExtensionManifestTest {

+// TODO(jamescook): Convert from ChromeManifestTest to ManifestTest.

+class FileHandlersManifestTest : public ChromeManifestTest {

};

TEST_F(FileHandlersManifestTest, InvalidFileHandlers) {