chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc - Issue 574173002: Reland: Refactor ExtensionManifestTest to allow usage in src/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc

Issue 574173002: Reland: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (manifest-test) add ScopedChannel Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_dummy_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc

index b376f4723aa41a3dbc706b7d7b0718293af9eb02..6c1b727dfcf69f759913ae0002260a0c51759cc8 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc

@@ -2,7 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

+#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

#include "base/command_line.h"

#include "extensions/common/extension.h"

@@ -13,7 +13,7 @@

namespace errors = extensions::manifest_errors;

-TEST_F(ExtensionManifestTest, ExperimentalPermission) {

+TEST_F(ChromeManifestTest, ExperimentalPermission) {

LoadAndExpectError("experimental.json", errors::kExperimentalFlagRequired);

LoadAndExpectSuccess("experimental.json", extensions::Manifest::COMPONENT);

LoadAndExpectSuccess("experimental.json", extensions::Manifest::INTERNAL,