Reland: Refactor ExtensionManifestTest to allow usage in src/extensions

chrome/common/extensions/manifest_tests/extension_manifest_test.h

Index: chrome/common/extensions/manifest_tests/extension_manifest_test.h
diff --git a/chrome/common/extensions/manifest_tests/extension_manifest_test.h b/chrome/common/extensions/manifest_tests/extension_manifest_test.h
deleted file mode 100644
index 6d68cf9d5b7c157b3a03bb4f55c263fa9faa037c..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/manifest_tests/extension_manifest_test.h
+++ /dev/null
@@ -1,165 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_
-#define CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_
-
-#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/values.h"
-#include "chrome/common/extensions/features/feature_channel.h"
-#include "extensions/common/extension.h"
-#include "extensions/common/manifest.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-class ExtensionManifestTest : public testing::Test {
- public:
-  ExtensionManifestTest();
-
- protected:
-  // Helper class that simplifies creating methods that take either a filename
-  // to a manifest or the manifest itself.
-  class Manifest {
-   public:
-    explicit Manifest(const char* name);
-    Manifest(base::DictionaryValue* manifest, const char* name);
-    explicit Manifest(scoped_ptr<base::DictionaryValue> manifest);
-    // C++98 requires the copy constructor for a type to be visible if you
-    // take a const-ref of a temporary for that type.  Since Manifest
-    // contains a scoped_ptr, its implicit copy constructor is declared
-    // Manifest(Manifest&) according to spec 12.8.5.  This breaks the first
-    // requirement and thus you cannot use it with LoadAndExpectError() or
-    // LoadAndExpectSuccess() easily.
-    //
-    // To get around this spec pedantry, we declare the copy constructor
-    // explicitly.  It will never get invoked.
-    Manifest(const Manifest& m);
-
-    ~Manifest();
-
-    const std::string& name() const { return name_; };
-
-    base::DictionaryValue* GetManifest(char const* test_data_dir,
-                                       std::string* error) const;
-
-   private:
-    const std::string name_;
-    mutable base::DictionaryValue* manifest_;
-    mutable scoped_ptr<base::DictionaryValue> manifest_holder_;
-  };
-
-  // The subdirectory in which to find test data files.
-  virtual char const* test_data_dir();
-
-  scoped_ptr<base::DictionaryValue> LoadManifest(
-      char const* manifest_name,
-      std::string* error);
-
-  scoped_refptr<extensions::Extension> LoadExtension(
-      const Manifest& manifest,
-      std::string* error,
-      extensions::Manifest::Location location =
-          extensions::Manifest::INTERNAL,
-      int flags = extensions::Extension::NO_FLAGS);
-
-  scoped_refptr<extensions::Extension> LoadAndExpectSuccess(
-      const Manifest& manifest,
-      extensions::Manifest::Location location =
-          extensions::Manifest::INTERNAL,
-      int flags = extensions::Extension::NO_FLAGS);
-
-  scoped_refptr<extensions::Extension> LoadAndExpectSuccess(
-      char const* manifest_name,
-      extensions::Manifest::Location location =
-          extensions::Manifest::INTERNAL,
-      int flags = extensions::Extension::NO_FLAGS);
-
-  // Load and expect success from a manifest provided as a json string. Single
-  // quotes will be replaced with double quotes for test readability.
-  scoped_refptr<extensions::Extension> LoadFromStringAndExpectSuccess(
-      char const* manifest_json);
-
-  scoped_refptr<extensions::Extension> LoadAndExpectWarning(
-      const Manifest& manifest,
-      const std::string& expected_error,
-      extensions::Manifest::Location location =
-          extensions::Manifest::INTERNAL,
-      int flags = extensions::Extension::NO_FLAGS);
-
-  scoped_refptr<extensions::Extension> LoadAndExpectWarning(
-      char const* manifest_name,
-      const std::string& expected_error,
-      extensions::Manifest::Location location =
-          extensions::Manifest::INTERNAL,
-      int flags = extensions::Extension::NO_FLAGS);
-
-  void VerifyExpectedError(extensions::Extension* extension,
-                           const std::string& name,
-                           const std::string& error,
-                           const std::string& expected_error);
-
-  void LoadAndExpectError(char const* manifest_name,
-                          const std::string& expected_error,
-                          extensions::Manifest::Location location =
-                              extensions::Manifest::INTERNAL,
-                          int flags = extensions::Extension::NO_FLAGS);
-
-  void LoadAndExpectError(const Manifest& manifest,
-                          const std::string& expected_error,
-                          extensions::Manifest::Location location =
-                              extensions::Manifest::INTERNAL,
-                          int flags = extensions::Extension::NO_FLAGS);
-
-  // Load and expect an error from a manifest provided as a json string. Single
-  // quotes will be replaced with double quotes for test readability.
-  void LoadFromStringAndExpectError(char const* manifest_json,
-                                    const std::string& expected_error);
-
-  void AddPattern(extensions::URLPatternSet* extent,
-                  const std::string& pattern);
-
-  // used to differentiate between calls to LoadAndExpectError,
-  // LoadAndExpectWarning and LoadAndExpectSuccess via function RunTestcases.
-  enum ExpectType {
-    EXPECT_TYPE_ERROR,
-    EXPECT_TYPE_WARNING,
-    EXPECT_TYPE_SUCCESS
-  };
-
-  struct Testcase {
-    std::string manifest_filename_;
-    std::string expected_error_; // only used for ExpectedError tests
-    extensions::Manifest::Location location_;
-    int flags_;
-
-    Testcase(std::string manifest_filename, std::string expected_error,
-        extensions::Manifest::Location location, int flags);
-
-    Testcase(std::string manifest_filename, std::string expected_error);
-
-    explicit Testcase(std::string manifest_filename);
-
-    Testcase(std::string manifest_filename,
-             extensions::Manifest::Location location,
-             int flags);
-  };
-
-  void RunTestcases(const Testcase* testcases,
-                    size_t num_testcases,
-                    ExpectType type);
-
-  void RunTestcase(const Testcase& testcase, ExpectType type);
-
-  bool enable_apps_;
-
-  // Force the manifest tests to run as though they are on trunk, since several
-  // tests rely on manifest features being available that aren't on
-  // stable/beta.
-  //
-  // These objects nest, so if a test wants to explicitly test the behaviour
-  // on stable or beta, declare it inside that test.
-  extensions::ScopedCurrentChannel current_channel_;
-};
-
-#endif  // CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_