Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 574173002: Reland: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (manifest-test) add ScopedChannel Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // These tests make sure SettingsOverridePermission values are set correctly. 5 // These tests make sure SettingsOverridePermission values are set correctly.
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
11 #include "extensions/common/manifest_constants.h" 11 #include "extensions/common/manifest_constants.h"
12 #include "extensions/common/permissions/permission_set.h" 12 #include "extensions/common/permissions/permission_set.h"
13 #include "extensions/common/permissions/permissions_data.h" 13 #include "extensions/common/permissions/permissions_data.h"
14 #include "extensions/common/permissions/settings_override_permission.h" 14 #include "extensions/common/permissions/settings_override_permission.h"
15 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 namespace { 19 namespace {
20 20
21 class SettingsOverridePermissionTest : public ExtensionManifestTest { 21 class SettingsOverridePermissionTest : public ChromeManifestTest {
22 protected: 22 protected:
23 enum Flags { 23 enum Flags {
24 kHomepage = 1, 24 kHomepage = 1,
25 kStartupPages = 1 << 1, 25 kStartupPages = 1 << 1,
26 kSearchProvider = 1 << 2, 26 kSearchProvider = 1 << 2,
27 }; 27 };
28 28
29 scoped_refptr<Extension> GetPermissionSet(uint32 flags) { 29 scoped_refptr<Extension> GetPermissionSet(uint32 flags) {
30 base::DictionaryValue ext_manifest; 30 base::DictionaryValue ext_manifest;
31 ext_manifest.SetString(manifest_keys::kName, "test"); 31 ext_manifest.SetString(manifest_keys::kName, "test");
(...skipping 17 matching lines...) Expand all
49 search_provider->SetString("keyword", "lock"); 49 search_provider->SetString("keyword", "lock");
50 search_provider->SetString("encoding", "UTF-8"); 50 search_provider->SetString("encoding", "UTF-8");
51 search_provider->SetBoolean("is_default", true); 51 search_provider->SetBoolean("is_default", true);
52 search_provider->SetString("favicon_url", 52 search_provider->SetString("favicon_url",
53 "http://wikipedia.org/wiki/Favicon"); 53 "http://wikipedia.org/wiki/Favicon");
54 settings_override->Set("search_provider", search_provider.release()); 54 settings_override->Set("search_provider", search_provider.release());
55 } 55 }
56 ext_manifest.Set( 56 ext_manifest.Set(
57 manifest_keys::kSettingsOverride, settings_override.release()); 57 manifest_keys::kSettingsOverride, settings_override.release());
58 58
59 Manifest manifest(&ext_manifest, "test"); 59 ManifestData manifest(&ext_manifest, "test");
60 return LoadAndExpectSuccess(manifest); 60 return LoadAndExpectSuccess(manifest);
61 } 61 }
62 }; 62 };
63 63
64 TEST_F(SettingsOverridePermissionTest, HomePage) { 64 TEST_F(SettingsOverridePermissionTest, HomePage) {
65 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage)); 65 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage));
66 scoped_refptr<const PermissionSet> permission_set( 66 scoped_refptr<const PermissionSet> permission_set(
67 extension->permissions_data()->active_permissions()); 67 extension->permissions_data()->active_permissions());
68 68
69 #if defined(OS_WIN) 69 #if defined(OS_WIN)
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 164 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
165 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 165 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
166 EXPECT_FALSE( 166 EXPECT_FALSE(
167 permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 167 permission_set->HasAPIPermission(APIPermission::kSearchProvider));
168 #endif 168 #endif
169 } 169 }
170 170
171 } // namespace 171 } // namespace
172 172
173 } // namespace extensions 173 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/manifest_unittest.cc ('k') | chrome/test/data/extensions/manifest_tests/shared_module_export.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698