Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: chrome/common/extensions/manifest_handlers/exclude_matches_manifest_unittest.cc

Issue 574173002: Reland: Refactor ExtensionManifestTest to allow usage in src/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (manifest-test) add ScopedChannel Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
7 #include "extensions/common/extension.h" 6 #include "extensions/common/extension.h"
8 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
9 8
10 namespace extensions { 9 namespace extensions {
11 10
12 class ExcludeMatchesManifestTest : public ExtensionManifestTest { 11 class ExcludeMatchesManifestTest : public ChromeManifestTest {
13 }; 12 };
14 13
15 TEST_F(ExcludeMatchesManifestTest, ExcludeMatchPatterns) { 14 TEST_F(ExcludeMatchesManifestTest, ExcludeMatchPatterns) {
16 Testcase testcases[] = { 15 Testcase testcases[] = {
17 Testcase("exclude_matches.json"), 16 Testcase("exclude_matches.json"),
18 Testcase("exclude_matches_empty.json") 17 Testcase("exclude_matches_empty.json")
19 }; 18 };
20 RunTestcases(testcases, arraysize(testcases), 19 RunTestcases(testcases, arraysize(testcases),
21 EXPECT_TYPE_SUCCESS); 20 EXPECT_TYPE_SUCCESS);
22 21
23 Testcase testcases2[] = { 22 Testcase testcases2[] = {
24 Testcase("exclude_matches_not_list.json", 23 Testcase("exclude_matches_not_list.json",
25 "Invalid value for 'content_scripts[0].exclude_matches'."), 24 "Invalid value for 'content_scripts[0].exclude_matches'."),
26 Testcase("exclude_matches_invalid_host.json", 25 Testcase("exclude_matches_invalid_host.json",
27 "Invalid value for 'content_scripts[0].exclude_matches[0]': " 26 "Invalid value for 'content_scripts[0].exclude_matches[0]': "
28 "Invalid host wildcard.") 27 "Invalid host wildcard.")
29 }; 28 };
30 RunTestcases(testcases2, arraysize(testcases2), 29 RunTestcases(testcases2, arraysize(testcases2),
31 EXPECT_TYPE_ERROR); 30 EXPECT_TYPE_ERROR);
32 } 31 }
33 32
34 } // namespace extensions 33 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698