Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574153002: Fail early if rtc::Thread::WrapCurrent failed to get more information for debugging. (Closed)

Created:
6 years, 3 months ago by jiayl
Modified:
6 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fail early if rtc::Thread::WrapCurrent failed to get more information for debugging. BUG=413853 Committed: https://crrev.com/18d64fc1c7ffa892066b04fd876c5206282fbbf0 Cr-Commit-Position: refs/heads/master@{#295170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M jingle/glue/thread_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jiayl
PTAL
6 years, 3 months ago (2014-09-16 21:26:53 UTC) #2
Sergey Ulanov
lgtm
6 years, 3 months ago (2014-09-16 21:32:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574153002/1
6 years, 3 months ago (2014-09-16 21:36:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/16099) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/16121)
6 years, 3 months ago (2014-09-16 21:48:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574153002/1
6 years, 3 months ago (2014-09-16 21:57:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 71dbf26a3f42f82cd624a4346900ce2212878bd0
6 years, 3 months ago (2014-09-16 23:04:04 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 23:04:37 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/18d64fc1c7ffa892066b04fd876c5206282fbbf0
Cr-Commit-Position: refs/heads/master@{#295170}

Powered by Google App Engine
This is Rietveld 408576698