Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 574143002: Center dialogs before computing overflow. (Closed)

Created:
6 years, 3 months ago by skobes
Modified:
6 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Center dialogs before computing overflow. Otherwise, the RenderView's layoutOverflowRect() is computed as if the dialog were positioned inline. BUG=403136 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182130

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -51 lines) Patch
A LayoutTests/dialog/modal-dialog-scroll-height.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A + LayoutTests/dialog/modal-dialog-scroll-height-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 3 chunks +34 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
skobes
6 years, 3 months ago (2014-09-16 21:20:06 UTC) #2
esprehn
Leave out html, body and head elements from the test. Also don't abbreviate in the ...
6 years, 3 months ago (2014-09-17 00:01:38 UTC) #3
skobes
On 2014/09/17 00:01:38, esprehn wrote: > Leave out html, body and head elements from the ...
6 years, 3 months ago (2014-09-17 00:11:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574143002/20001
6 years, 3 months ago (2014-09-17 00:11:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 01:31:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182130

Powered by Google App Engine
This is Rietveld 408576698