athena/test/athena_test_helper.cc - Issue 574113002: Use chromeos accelerometer reader and support only lid accelerometer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/test/athena_test_helper.cc

Issue 574113002: Use chromeos accelerometer reader and support only lid accelerometer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use BlockingPool for athena and fix nit. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/test/athena_test_helper.cc

diff --git a/athena/test/athena_test_helper.cc b/athena/test/athena_test_helper.cc

index ec0fe2ea21950e23d11570c27b98914232b48002..b20490c02b352489670d3722631186de25f40c12 100644

--- a/athena/test/athena_test_helper.cc

+++ b/athena/test/athena_test_helper.cc

@@ -60,6 +60,7 @@ void AthenaTestHelper::SetUp(ui::ContextFactory* context_factory) {

aura::test::EnvTestHelper(aura::Env::GetInstance())

.SetInputStateLookup(scoped_ptr<aura::InputStateLookup>());

+ // TODO(oshima): Use a BlockingPool task runner.

oshima 2014/09/16 22:33:04 You may leave the comment, but I think this is ok

athena::StartAthenaEnv(file_thread_->message_loop_proxy());

athena::ExtensionsDelegate::CreateExtensionsDelegateForTest();

athena::StartAthenaSession(new SampleActivityFactory(),

« no previous file with comments | « athena/system/system_ui_impl.cc ('k') | chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc » ('j') | no next file with comments »