Use chromeos accelerometer reader and support only lid accelerometer.

Use chromeos accelerometer reader in athena and support only lid accelerometer.

BUG=380831
TEST=Glimmer/clapper still work, manually tested not having a base accelerometer.

Committed: https://crrev.com/2aa8d2e93a06cc7673c872704c04e933bd6cc252
Cr-Commit-Position: refs/heads/master@{#295258}

[flackr, 2014-09-16 20:57:52]

flackr@chromium.org changed reviewers:
+ derat@chromium.org, oshima@chromium.org

[flackr, 2014-09-16 20:57:53]

PTAL, this adds support for only having some of the supported accelerometers and
uses chromeos/accelerometer/accelerometer_reader.cc to provide readings for
athena rather than having special code there.

[oshima, 2014-09-16 21:27:17]

nice!

https://codereview.chromium.org/574113002/diff/1/chrome/browser/ui/ash/ash_in...
File chrome/browser/ui/ash/ash_init.cc (right):

https://codereview.chromium.org/574113002/diff/1/chrome/browser/ui/ash/ash_in...
chrome/browser/ui/ash/ash_init.cc:76: content::BrowserThread::FILE));
FILE thread is obsolete and we should use BlockingPool. It was my mistake that I
used FILE thread in athena+chrome. I'll fix it.

[Daniel Erat, 2014-09-16 21:41:03]

lgtm modulo oshima's comment

https://codereview.chromium.org/574113002/diff/1/chromeos/accelerometer/accel...
File chromeos/accelerometer/accelerometer_reader.cc (right):

https://codereview.chromium.org/574113002/diff/1/chromeos/accelerometer/accel...
chromeos/accelerometer/accelerometer_reader.cc:32: const
base::FilePath::CharType kAccelerometerScaleName[] = "in_accel_%s_scale";
nit: kScaleNameFormatString?

[flackr, 2014-09-16 22:19:05]

Patchset #2 (id:20001) has been deleted

[flackr, 2014-09-16 22:19:23]

https://codereview.chromium.org/574113002/diff/1/chrome/browser/ui/ash/ash_in...
File chrome/browser/ui/ash/ash_init.cc (right):

https://codereview.chromium.org/574113002/diff/1/chrome/browser/ui/ash/ash_in...
chrome/browser/ui/ash/ash_init.cc:76: content::BrowserThread::FILE));
On 2014/09/16 21:27:16, oshima wrote:
> FILE thread is obsolete and we should use BlockingPool. It was my mistake that
I
> used FILE thread in athena+chrome. I'll fix it.

Done, and updated athena/ except for AthenaTestHelper.

https://codereview.chromium.org/574113002/diff/1/chromeos/accelerometer/accel...
File chromeos/accelerometer/accelerometer_reader.cc (right):

https://codereview.chromium.org/574113002/diff/1/chromeos/accelerometer/accel...
chromeos/accelerometer/accelerometer_reader.cc:32: const
base::FilePath::CharType kAccelerometerScaleName[] = "in_accel_%s_scale";
On 2014/09/16 21:41:03, Daniel Erat wrote:
> nit: kScaleNameFormatString?

Done.

[oshima, 2014-09-16 22:33:04]

lgtm

https://codereview.chromium.org/574113002/diff/40001/athena/test/athena_test_...
File athena/test/athena_test_helper.cc (right):

https://codereview.chromium.org/574113002/diff/40001/athena/test/athena_test_...
athena/test/athena_test_helper.cc:63: // TODO(oshima): Use a BlockingPool task
runner.
You may leave the comment, but I think this is ok as it's not a
BrowserThread::FILE.

[flackr, 2014-09-16 23:51:06]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-09-16 23:52:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/574113002/40001

[commit-bot: I haz the power, 2014-09-16 23:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 23:57:50]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56830)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[flackr, 2014-09-17 00:30:57]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-09-17 00:33:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/574113002/60001

[commit-bot: I haz the power, 2014-09-17 02:34:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 02:34:18]

Exceeded time limit waiting for builds to trigger.

[flackr, 2014-09-17 11:55:32]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-09-17 11:56:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/574113002/60001

[commit-bot: I haz the power, 2014-09-17 12:20:46]

Committed patchset #3 (id:60001) as a425b788611091443e3ba7662c3d92f1786edefa

[commit-bot: I haz the power, 2014-09-17 12:21:19]

Patchset 3 (id:??) landed as
https://crrev.com/2aa8d2e93a06cc7673c872704c04e933bd6cc252
Cr-Commit-Position: refs/heads/master@{#295258}

[battre, 2014-09-17 12:52:43]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/571283006/ by battre@chromium.org.

The reason for reverting is: Breaks ChromeOS compilation
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

[flackr, 2014-09-17 12:53:55]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/553913003/ by flackr@chromium.org.

The reason for reverting is: Broke compile on
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....