Remove keyboard usability mode

Remove keyboard usability mode

BUG=414766
Committed: https://crrev.com/9858b4ad01cf2220d18acdc8cb7cbae328974d33
Cr-Commit-Position: refs/heads/master@{#295140}

[bshe, 2014-09-16 16:03:46]

bshe@chromium.org changed reviewers:
+ oshima@chromium.org

[bshe, 2014-09-16 16:04:39]

Hey Oshima

Do you mind to take a look at this CL? It simply remove the keyboard usablity
mode.

Thanks

[oshima, 2014-09-16 16:59:26]

can you check compilation error?

https://codereview.chromium.org/574033003/diff/1/chrome/browser/ui/views/ash/...
File chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc (right):

https://codereview.chromium.org/574033003/diff/1/chrome/browser/ui/views/ash/...
chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:22: #include
"ui/keyboard/keyboard_util.h"
you don't need these two?

https://codereview.chromium.org/574033003/diff/1/ui/keyboard/keyboard_control...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/574033003/diff/1/ui/keyboard/keyboard_control...
ui/keyboard/keyboard_controller.cc:29: #include
"ui/keyboard/keyboard_switches.h"
do you need this?

[bshe, 2014-09-16 18:10:31]

Sorry, I forgot to test keyboard_unittest.

All the compile errors should been fixed now. Do you mind to take another look?

THanks

https://codereview.chromium.org/574033003/diff/1/chrome/browser/ui/views/ash/...
File chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc (right):

https://codereview.chromium.org/574033003/diff/1/chrome/browser/ui/views/ash/...
chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:22: #include
"ui/keyboard/keyboard_util.h"
On 2014/09/16 16:59:26, oshima wrote:
> you don't need these two?

Looks like keyboard_util.h can be removed but keyboard_controller is still
needed.

https://codereview.chromium.org/574033003/diff/1/ui/keyboard/keyboard_control...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/574033003/diff/1/ui/keyboard/keyboard_control...
ui/keyboard/keyboard_controller.cc:29: #include
"ui/keyboard/keyboard_switches.h"
On 2014/09/16 16:59:26, oshima wrote:
> do you need this?

removed

[oshima, 2014-09-16 18:45:37]

lgtm

[bshe, 2014-09-16 19:50:28]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:51:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/574033003/20001

[commit-bot: I haz the power, 2014-09-16 20:01:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 20:01:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bshe, 2014-09-16 20:32:49]

bshe@chromium.org changed reviewers:
+ jamescook@chromium.org

[bshe, 2014-09-16 20:32:49]

+jamescook
for chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc

[James Cook, 2014-09-16 20:39:18]

lgtm

[bshe, 2014-09-16 20:40:08]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-09-16 20:41:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/574033003/20001

[commit-bot: I haz the power, 2014-09-16 20:46:50]

Committed patchset #2 (id:20001) as 6517319cbeb184fa5c51427e420420be5e269b2c

[commit-bot: I haz the power, 2014-09-16 20:47:23]

Patchset 2 (id:??) landed as
https://crrev.com/9858b4ad01cf2220d18acdc8cb7cbae328974d33
Cr-Commit-Position: refs/heads/master@{#295140}