Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574023002: GuestView should Self destruct if the embedder doesn't have permission. (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GuestView should Self destruct if the embedder doesn't have permission. BUG=none TBR=fsamuel@chromium.org Committed: https://crrev.com/fe44b05a8a7aa95be39b44fe29bdbaf323be18d7 Cr-Commit-Position: refs/heads/master@{#295082}

Patch Set 1 #

Patch Set 2 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M extensions/browser/guest_view/guest_view_base.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Fady Samuel
6 years, 3 months ago (2014-09-16 14:06:43 UTC) #2
Xi Han
lgtm
6 years, 3 months ago (2014-09-16 14:16:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574023002/20001
6 years, 3 months ago (2014-09-16 14:19:47 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-16 14:19:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574023002/20001
6 years, 3 months ago (2014-09-16 15:47:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7eacda5d21216b7dbb7a8f88c5bbecd91854f6bb
6 years, 3 months ago (2014-09-16 16:47:10 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 16:48:37 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fe44b05a8a7aa95be39b44fe29bdbaf323be18d7
Cr-Commit-Position: refs/heads/master@{#295082}

Powered by Google App Engine
This is Rietveld 408576698