Clean up GestureEventDetails constructors and fix unit tests

Clean up GestureEventDetails constructors and fix unit tests.

A new version of Issue 565583005: Clean up GestureEventDetails
constructors
https://codereview.chromium.org/565583005/

BUG=350942
TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5
Cr-Commit-Position: refs/heads/master@{#295144}

Committed: https://crrev.com/66e0c057b87824c6e6928f359fa56a8ee45ae6e2
Cr-Commit-Position: refs/heads/master@{#295296}

Committed: https://crrev.com/9ec877c2d256a538b1c9af2fbed736aad8406e66
Cr-Commit-Position: refs/heads/master@{#295329}

[lanwei, 2014-09-16 15:48:42]

Patchset #1 (id:1) has been deleted

[lanwei, 2014-09-16 15:54:09]

Tim, can you please take a look at
athena/home/home_card_gesture_manager_unittest.cc?
Thank you.

[tdresser, 2014-09-16 15:57:25]

On 2014/09/16 15:54:09, lanwei wrote:
> Tim, can you please take a look at
> athena/home/home_card_gesture_manager_unittest.cc?
> Thank you.

LGTM.

I think you can safely TBR= the other reviewers.

[lanwei, 2014-09-16 17:31:36]

lanwei@chromium.org changed reviewers:
+ sky@chromium.org

[lanwei, 2014-09-16 17:37:26]

sky@, can you please take a look at
athena/home/home_card_gesture_manager_unittest.cc?
I missed this file in last cl https://codereview.chromium.org/565583005/.
Thank you.

[sky, 2014-09-16 19:48:00]

LGTM

[lanwei, 2014-09-16 19:48:38]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2014-09-16 19:49:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/573963005/20001

[commit-bot: I haz the power, 2014-09-16 21:29:24]

Committed patchset #1 (id:20001) as 88c94f31a3ba416dc2c8c29367ed7b68cf34daa6

[commit-bot: I haz the power, 2014-09-16 21:30:01]

Patchset 1 (id:??) landed as
https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5
Cr-Commit-Position: refs/heads/master@{#295144}

[horo, 2014-09-17 03:47:44]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/577833003/ by horo@chromium.org.

The reason for reverting is: This broke
TouchEditableImplAuraTest.TouchSelectionOnLongPressTest.
[24874:24874:0916/151803:584385367:FATAL:gesture_event_details.cc(54)] Check
failed: false. Invalid event type for constructor: 32
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=und...

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=und....

[lanwei, 2014-09-17 17:51:59]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2014-09-17 17:53:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/573963005/20001

[commit-bot: I haz the power, 2014-09-17 17:54:24]

Committed patchset #1 (id:20001) as b44589c531098bbe739ccc7066f41e17fc5b9287

[commit-bot: I haz the power, 2014-09-17 17:54:59]

Patchset 1 (id:??) landed as
https://crrev.com/66e0c057b87824c6e6928f359fa56a8ee45ae6e2
Cr-Commit-Position: refs/heads/master@{#295296}

[lanwei, 2014-09-17 19:29:11]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2014-09-17 19:30:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/573963005/60001

[commit-bot: I haz the power, 2014-09-17 20:03:45]

Committed patchset #3 (id:60001) as 79238376c0d8778f5103657a2cc5772856182cad

[commit-bot: I haz the power, 2014-09-17 20:04:19]

Patchset 3 (id:??) landed as
https://crrev.com/9ec877c2d256a538b1c9af2fbed736aad8406e66
Cr-Commit-Position: refs/heads/master@{#295329}

[lanwei, 2014-09-17 20:06:33]

On 2014/09/17 17:54:59, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/66e0c057b87824c6e6928f359fa56a8ee45ae6e2
> Cr-Commit-Position: refs/heads/master@{#295296}

There are some conflicts in the
content/browser/web_contents/touch_editable_impl_aura_browsertest.cc, so I
downloaded the latest version and made a change to it.

[Dan Beam, 2014-09-17 21:47:27]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/580973002/ by dbeam@chromium.org.

The reason for reverting is: this may have broken wm_unittests on XP Tests (3):
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(3)/builds/28989

WindowAnimationsTest.HideAnimationDetachLayers (run #1):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149):
error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(),
false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150):
error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151):
error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155):
error: Expected: (animating_window->layer()) != (animating_layer), actual:
0017B9D8 vs 0017B9D8
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188):
error: Value of: std::find(parent->layer()->children().begin(),
parent->layer()->children().end(), animating_layer) ==
parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (141 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #2):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149):
error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(),
false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150):
error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151):
error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155):
error: Expected: (animating_window->layer()) != (animating_layer), actual:
0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slaveWindowAnimationsTest.HideAnimationDetachLayers (run #1):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149):
error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(),
false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150):
error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151):
error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155):
error: Expected: (animating_window->layer()) != (animating_layer), actual:
0017B9D8 vs 0017B9D8
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188):
error: Value of: std::find(parent->layer()->children().begin(),
parent->layer()->children().end(), animating_layer) ==
parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (141 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #2):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149):
error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(),
false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150):
error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151):
error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155):
error: Expected: (animating_window->layer()) != (animating_layer), actual:
0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188):
error: Value of: std::find(parent->layer()->children().begin(),
parent->layer()->children().end(), animating_layer) ==
parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (94 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #3):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149):
error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(),
false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150):
error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151):
error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155):
error: Expected: (animating_window->layer()) != (animating_layer), actual:
0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188):
error: Value of: std::find(parent->layer()->children().begin(),
parent->layer()->children().end(), animating_layer) ==
parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #4):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149):
error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(),
false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150):
error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151):
error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155):
error: Expected: (animating_window->layer()) != (animating_layer), actual:
0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188):
error: Value of: std::find(parent->layer()->children().begin(),
parent->layer()->children().end(), animating_layer) ==
parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (47
ms)\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180): error:
Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188):
error: Value of: std::find(parent->layer()->children().begin(),
parent->layer()->children().end(), animating_layer) ==
parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (94 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #3):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149):
error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(),
false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150):
error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151):
error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155):
error: Expected: (animating_window->layer()) != (animating_layer), actual:
0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188):
error: Value of: std::find(parent->layer()->children().begin(),
parent->layer()->children().end(), animating_layer) ==
parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms)

WindowAnimationsTest.HideAnimationDetachLayers (run #4):
[ RUN      ] WindowAnimationsTest.HideAnimationDetachLayers
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(149):
error: Value of: AnimateOnChildWindowVisibilityChanged( animating_window.get(),
false)
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(150):
error: Value of: animating_layer->GetAnimator()->is_animating()
  Actual: false
Expected: true
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(151):
error: Value of: animating_layer->delegate()
  Actual: true
Expected: false
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(155):
error: Expected: (animating_window->layer()) != (animating_layer), actual:
0017B318 vs 0017B318
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(171):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 1
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(180):
error: Value of: GetLayerZPosition(animating_layer)
  Actual: 0
Expected: 2
c:\b\build\slave\win_builder\build\src\ui\wm\core\window_animations_unittest.cc(188):
error: Value of: std::find(parent->layer()->children().begin(),
parent->layer()->children().end(), animating_layer) ==
parent->layer()->children().end()
  Actual: false
Expected: true
[  FAILED  ] WindowAnimationsTest.HideAnimationDetachLayers (47 ms).