Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 573963003: Enable ES6 generators (Closed)

Created:
6 years, 3 months ago by wingo
Modified:
6 years, 3 months ago
Reviewers:
aandrey, rossberg, Yang
CC:
v8-dev, marja, Dmitry Lomov (no reviews), Michael Starzinger
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -132 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 6 chunks +63 lines, -73 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/parser.cc View 3 chunks +1 line, -3 lines 0 comments Download
M src/preparser.h View 5 chunks +1 line, -5 lines 0 comments Download
M src/preparser.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 8 chunks +11 lines, -30 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-debug-liveedit.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-debug-scopes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-iteration.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-objects.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-parsing.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/generators-poisoned-properties.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/generators-relocation.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-runtime.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/iteration-semantics.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-2681.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-2691.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regress/regress-3280.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress-3225.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
wingo
6 years, 3 months ago (2014-09-16 11:51:18 UTC) #1
rossberg
lgtm
6 years, 3 months ago (2014-09-16 12:15:28 UTC) #2
wingo
Committed patchset #2 manually as 23974 (presubmit successful).
6 years, 3 months ago (2014-09-16 12:31:02 UTC) #3
aandrey
We should provide debugging support for generators before releasing. Can we prioritize this work (https://code.google.com/p/v8/issues/detail?id=3292)?
6 years, 3 months ago (2014-09-16 14:12:12 UTC) #5
Yang
6 years, 3 months ago (2014-09-16 14:14:03 UTC) #6
Message was sent while issue was closed.
On 2014/09/16 14:12:12, aandrey wrote:
> We should provide debugging support for generators before releasing. Can we
> prioritize this work (https://code.google.com/p/v8/issues/detail?id=3292)?

I think it's fine to enable it. Generators won't cause the debugger to crash, as
far as we can make sure. The second step of adding specific support should not
block this feature.

Powered by Google App Engine
This is Rietveld 408576698