Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 573933002: Cleanup: Remove remaining generated extensions APIs on Android. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@extclean4
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove remaining generated extensions APIs on Android. BUG=305852 Committed: https://crrev.com/379f0be47f454cce5c912f25d1b3302ba679b472 Cr-Commit-Position: refs/heads/master@{#295669}

Patch Set 1 #

Patch Set 2 : fix tests #

Patch Set 3 : rebase #

Patch Set 4 : fix build some more after rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -73 lines) Patch
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc View 1 6 chunks +10 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 5 chunks +40 lines, -40 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 6 chunks +9 lines, -10 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 2 5 chunks +14 lines, -2 lines 0 comments Download
M extensions/common/api/schemas.gypi View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Lei Zhang
Depends on https://codereview.chromium.org/578483002/ Finished renderer -> time to remove common
6 years, 3 months ago (2014-09-16 00:27:38 UTC) #2
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-16 00:31:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573933002/1
6 years, 3 months ago (2014-09-16 02:54:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/4742) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/9070)
6 years, 3 months ago (2014-09-16 03:41:37 UTC) #7
Lei Zhang
Patch set 2 makes Android happy. The problem was I had the generated API headers ...
6 years, 3 months ago (2014-09-16 21:51:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573933002/20001
6 years, 3 months ago (2014-09-18 23:01:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11203) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/11760)
6 years, 3 months ago (2014-09-18 23:13:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/573933002/60001
6 years, 3 months ago (2014-09-19 05:18:12 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 2047ab90b4bcaef1b7169acd1ae883fabb237e80
6 years, 3 months ago (2014-09-19 05:44:30 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/379f0be47f454cce5c912f25d1b3302ba679b472 Cr-Commit-Position: refs/heads/master@{#295669}
6 years, 3 months ago (2014-09-19 05:45:46 UTC) #16
Lei Zhang
6 years, 3 months ago (2014-09-19 06:19:23 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/582933003/ by thestig@chromium.org.

The reason for reverting is: Android bot fails with error:
gen/extensions/common/api/generated_schemas.cc: No such file or directory
.

Powered by Google App Engine
This is Rietveld 408576698