Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: net/proxy/multi_threaded_proxy_resolver.cc

Issue 573893004: Remove some unused proxy-related histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add back 3 deprecated histograms Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/dhcp_proxy_script_fetcher_win.cc ('k') | net/proxy/proxy_resolver_v8_tracing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/multi_threaded_proxy_resolver.cc
diff --git a/net/proxy/multi_threaded_proxy_resolver.cc b/net/proxy/multi_threaded_proxy_resolver.cc
index cab22ab275909f96b0c3eb29583fe3e589d87d68..4b68321a4023d5df4b2c9b1944ff1b6107931eb2 100644
--- a/net/proxy/multi_threaded_proxy_resolver.cc
+++ b/net/proxy/multi_threaded_proxy_resolver.cc
@@ -7,7 +7,6 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/message_loop/message_loop_proxy.h"
-#include "base/metrics/histogram.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/threading/thread.h"
@@ -219,7 +218,6 @@ class MultiThreadedProxyResolver::GetProxyForURLJob
url_(url),
was_waiting_for_thread_(false) {
DCHECK(!callback.is_null());
- start_time_ = base::TimeTicks::Now();
}
BoundNetLog* net_log() { return &net_log_; }
@@ -232,8 +230,6 @@ class MultiThreadedProxyResolver::GetProxyForURLJob
virtual void FinishedWaitingForThread() OVERRIDE {
DCHECK(executor());
- submitted_to_thread_time_ = base::TimeTicks::Now();
-
if (was_waiting_for_thread_) {
net_log_.EndEvent(NetLog::TYPE_WAITING_FOR_PROXY_RESOLVER_THREAD);
}
@@ -263,7 +259,6 @@ class MultiThreadedProxyResolver::GetProxyForURLJob
void QueryComplete(int result_code) {
// The Job may have been cancelled after it was started.
if (!was_cancelled()) {
- RecordPerformanceMetrics();
if (result_code >= OK) { // Note: unit-tests use values > 0.
results_->Use(results_buf_);
}
@@ -272,20 +267,6 @@ class MultiThreadedProxyResolver::GetProxyForURLJob
OnJobCompleted();
}
- void RecordPerformanceMetrics() {
- DCHECK(!was_cancelled());
-
- base::TimeTicks now = base::TimeTicks::Now();
-
- // Log the total time the request took to complete.
- UMA_HISTOGRAM_MEDIUM_TIMES("Net.MTPR_GetProxyForUrl_Time",
- now - start_time_);
-
- // Log the time the request was stalled waiting for a thread to free up.
- UMA_HISTOGRAM_MEDIUM_TIMES("Net.MTPR_GetProxyForUrl_Thread_Wait_Time",
- submitted_to_thread_time_ - start_time_);
- }
-
// Must only be used on the "origin" thread.
ProxyInfo* results_;
@@ -296,9 +277,6 @@ class MultiThreadedProxyResolver::GetProxyForURLJob
// Usable from within DoQuery on the worker thread.
ProxyInfo results_buf_;
- base::TimeTicks start_time_;
- base::TimeTicks submitted_to_thread_time_;
-
bool was_waiting_for_thread_;
};
« no previous file with comments | « net/proxy/dhcp_proxy_script_fetcher_win.cc ('k') | net/proxy/proxy_resolver_v8_tracing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698