Avoid unnecessary visibility changes to BookmarkBarView

Avoid unnecessary visibility changes to BookmarkBarView

I came across this while investigating slowness. Without this we would
end up unnecessarily toggling visibility a couple of times. While not
the end of the world, toggling visibility for the bookmarkbar can take
a while (mostly because it can end up containing a ton of views).

BUG=none
TEST=covered by test now
R=jamescook@chromium.org

Committed: https://crrev.com/b32ecb13b8a14b08c5bfd74748e7f1f21798e134
Cr-Commit-Position: refs/heads/master@{#295116}

[James Cook, 2014-09-16 15:52:31]

LGTM

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.h (right):

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.h:457:
base::WeakPtrFactory<BookmarkBarView> show_folder_method_factory_;
Hooray for WeakPtrFactory cleanup!

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/browser_view_browsertest.cc (right):

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view_browsertest.cc:195: // Verifies we
don't unnecessarily change the visibility of the bookmarkbarview.
nit: "bookmarkbarview" to either "BookmarkBarView" or "bookmark bar view".

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view_browsertest.cc:198: // bookmarkbar
isn't shown (meaning it'll only be shown when on the ntp).
ditto: "bookmarkbar" just reads oddly to me

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view_browsertest.cc:241: }
Nice test.

[sky, 2014-09-16 16:22:08]

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/browser_view_browsertest.cc (right):

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view_browsertest.cc:195: // Verifies we
don't unnecessarily change the visibility of the bookmarkbarview.
On 2014/09/16 15:52:31, James Cook wrote:
> nit: "bookmarkbarview" to either "BookmarkBarView" or "bookmark bar view".

Done.

https://codereview.chromium.org/573893003/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_view_browsertest.cc:198: // bookmarkbar
isn't shown (meaning it'll only be shown when on the ntp).
On 2014/09/16 15:52:31, James Cook wrote:
> ditto: "bookmarkbar" just reads oddly to me

Done.

[sky, 2014-09-16 16:22:12]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-09-16 16:23:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/573893003/60001

[commit-bot: I haz the power, 2014-09-16 19:06:36]

Committed patchset #4 (id:60001) as eb70159048d402088f7a0a9b5c3fb04450598b47

[commit-bot: I haz the power, 2014-09-16 19:07:42]

Patchset 4 (id:??) landed as
https://crrev.com/b32ecb13b8a14b08c5bfd74748e7f1f21798e134
Cr-Commit-Position: refs/heads/master@{#295116}