Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 573843002: Allows webview to access extension resources. (Closed)

Created:
6 years, 3 months ago by lfg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Xi Han, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allows webview to access extension resources. BUG=352290 Committed: https://crrev.com/048201a30f26eaac525a8007288928d1abbd75f0 Cr-Commit-Position: refs/heads/master@{#295117}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Fix problems with early returns. #

Total comments: 1

Patch Set 5 : url_request_util -> chrome_url_request_util #

Patch Set 6 : Forgot to add the namespace on chrome_url_request_util.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -425 lines) Patch
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 2 3 4 4 chunks +10 lines, -4 lines 0 comments Download
A + chrome/browser/extensions/chrome_url_request_util.h View 1 2 3 4 3 chunks +12 lines, -14 lines 0 comments Download
A + chrome/browser/extensions/chrome_url_request_util.cc View 1 2 3 4 5 4 chunks +14 lines, -75 lines 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/url_request_util.h View 1 2 3 4 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/browser/extensions/url_request_util.cc View 1 2 3 4 1 chunk +0 lines, -252 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/url_request_util.h View 1 2 3 4 3 chunks +8 lines, -24 lines 0 comments Download
A extensions/browser/url_request_util.cc View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 15 (3 generated)
lfg
Hey Fady, could you take a look before I send it to extensions owners?
6 years, 3 months ago (2014-09-15 19:48:57 UTC) #2
Fady Samuel
https://codereview.chromium.org/573843002/diff/20001/chrome/browser/extensions/url_request_util.cc File chrome/browser/extensions/url_request_util.cc (right): https://codereview.chromium.org/573843002/diff/20001/chrome/browser/extensions/url_request_util.cc#newcode156 chrome/browser/extensions/url_request_util.cc:156: if (content::IsResourceTypeFrame(info->GetResourceType()) && !is_guest) It seems to me that ...
6 years, 3 months ago (2014-09-15 19:54:43 UTC) #3
lfg
https://codereview.chromium.org/573843002/diff/20001/chrome/browser/extensions/url_request_util.cc File chrome/browser/extensions/url_request_util.cc (right): https://codereview.chromium.org/573843002/diff/20001/chrome/browser/extensions/url_request_util.cc#newcode156 chrome/browser/extensions/url_request_util.cc:156: if (content::IsResourceTypeFrame(info->GetResourceType()) && !is_guest) On 2014/09/15 19:54:43, Fady Samuel ...
6 years, 3 months ago (2014-09-15 20:13:20 UTC) #4
lfg
https://codereview.chromium.org/573843002/diff/20001/chrome/browser/extensions/url_request_util.cc File chrome/browser/extensions/url_request_util.cc (right): https://codereview.chromium.org/573843002/diff/20001/chrome/browser/extensions/url_request_util.cc#newcode156 chrome/browser/extensions/url_request_util.cc:156: if (content::IsResourceTypeFrame(info->GetResourceType()) && !is_guest) On 2014/09/15 19:54:43, Fady Samuel ...
6 years, 3 months ago (2014-09-15 20:13:20 UTC) #5
lfg
rockot@chromium.org: Please review changes in All files.
6 years, 3 months ago (2014-09-15 20:14:17 UTC) #7
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/573843002/diff/60001/chrome/browser/extensions/url_request_util.h File chrome/browser/extensions/url_request_util.h (right): https://codereview.chromium.org/573843002/diff/60001/chrome/browser/extensions/url_request_util.h#newcode31 chrome/browser/extensions/url_request_util.h:31: bool ChromeAllowCrossRendererResourceLoad(net::URLRequest* request, Or you could change the ...
6 years, 3 months ago (2014-09-16 16:50:52 UTC) #8
lfg
PTAL, I renamed the namespace. On 2014/09/16 16:50:52, Ken Rockot wrote: > lgtm > > ...
6 years, 3 months ago (2014-09-16 17:09:07 UTC) #9
Ken Rockot(use gerrit already)
nice. still lgtm
6 years, 3 months ago (2014-09-16 17:13:01 UTC) #10
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-16 17:18:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573843002/100001
6 years, 3 months ago (2014-09-16 18:41:40 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 12c9f53024be1e030159c60a0d3368da219a12f6
6 years, 3 months ago (2014-09-16 19:10:22 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 19:11:38 UTC) #15
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/048201a30f26eaac525a8007288928d1abbd75f0
Cr-Commit-Position: refs/heads/master@{#295117}

Powered by Google App Engine
This is Rietveld 408576698