Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 573833002: SkPicture::PathCounter is O(N^2) for pictures nested N deep. Fix that. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkPicture::PathCounter is O(N^2) for pictures nested N deep. Fix that. We've already done the analysis for child pictures. Don't do it again. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4fc5b8811e8c2a09fcbb3714e44697079f9ec692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M src/core/SkPicture.cpp View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein
6 years, 3 months ago (2014-09-15 19:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573833002/1
6 years, 3 months ago (2014-09-15 19:23:31 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-15 19:23:33 UTC) #5
f(malita)
LGTM!
6 years, 3 months ago (2014-09-15 19:24:54 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 19:31:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 4fc5b8811e8c2a09fcbb3714e44697079f9ec692

Powered by Google App Engine
This is Rietveld 408576698