Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 57383010: Rename service subdir under chrome/browser to service_process (Closed)

Created:
7 years, 1 month ago by jianli
Modified:
7 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Rename service subdir under chrome/browser to service_process It is renamed because we're going to add new "services" directory which holds all google services related codes, like sync, invalidation and signin. We do not want to have both "service" and "services" to cause the confusion. Since all codes under "service" deal purely with service process, we would like to rename it to "service_process". BUG=none TEST=none due to that this is just a dir renaming R=thakis@chromium.org, vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -970 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/service/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/service/service_process_control.h View 1 chunk +0 lines, -219 lines 0 comments Download
D chrome/browser/service/service_process_control.cc View 1 chunk +0 lines, -406 lines 0 comments Download
D chrome/browser/service/service_process_control_browsertest.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D chrome/browser/service/service_process_control_mac.mm View 1 chunk +0 lines, -28 lines 0 comments Download
A + chrome/browser/service_process/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/service_process/service_process_control.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/service_process/service_process_control.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/service_process/service_process_control_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/service_process/service_process_control_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jianli
7 years, 1 month ago (2013-11-04 22:25:06 UTC) #1
Nico
Please answer "why" somewhere, either in a bug or in the cl description. From what ...
7 years, 1 month ago (2013-11-04 22:29:41 UTC) #2
jianli
On 2013/11/04 22:29:41, Nico wrote: > Please answer "why" somewhere, either in a bug or ...
7 years, 1 month ago (2013-11-04 22:40:08 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 1 month ago (2013-11-04 23:19:02 UTC) #4
Nico
lgtm
7 years, 1 month ago (2013-11-04 23:29:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/57383010/1
7 years, 1 month ago (2013-11-05 00:28:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/57383010/1
7 years, 1 month ago (2013-11-05 03:24:03 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184808
7 years, 1 month ago (2013-11-05 06:20:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/57383010/1
7 years, 1 month ago (2013-11-05 10:05:00 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97848
7 years, 1 month ago (2013-11-05 12:27:17 UTC) #10
jianli
7 years, 1 month ago (2013-11-05 17:55:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r233023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698