Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 57383009: Remove duplicate isLeapYear (Closed)

Created:
7 years, 1 month ago by rwlbuis
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove duplicate isLeapYear The function is already available from DateMath.h Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161294

Patch Set 1 #

Patch Set 2 : Fix export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M Source/platform/DateComponents.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/wtf/DateMath.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
rwlbuis
Simple duplication removal.
7 years, 1 month ago (2013-11-04 21:13:09 UTC) #1
rwlbuis
Simple code duplication removal patch.
7 years, 1 month ago (2013-11-04 21:29:51 UTC) #2
rwlbuis
I think I got the reviewers wrong first time, sorry :(
7 years, 1 month ago (2013-11-04 21:33:43 UTC) #3
Nico
lgtm Probably not performance-critical?
7 years, 1 month ago (2013-11-04 21:36:42 UTC) #4
rwlbuis
On 2013/11/04 21:36:42, Nico wrote: > lgtm > > Probably not performance-critical? Thanks! No, it ...
7 years, 1 month ago (2013-11-04 22:07:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/57383009/1
7 years, 1 month ago (2013-11-04 22:07:28 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-04 22:36:33 UTC) #7
rwlbuis
Oops, I failed to notice isLeapYear was not exported, maybe another review for sanity checking...
7 years, 1 month ago (2013-11-04 22:48:01 UTC) #8
Nico
still lgtm
7 years, 1 month ago (2013-11-04 22:48:42 UTC) #9
rwlbuis
On 2013/11/04 22:48:42, Nico wrote: > still lgtm That is quick, thnx :)
7 years, 1 month ago (2013-11-04 22:53:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/57383009/180001
7 years, 1 month ago (2013-11-04 22:53:47 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 00:33:59 UTC) #12
Message was sent while issue was closed.
Change committed as 161294

Powered by Google App Engine
This is Rietveld 408576698