Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 57383006: Avoid redundant assertion code in equality comparisons in checked mode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 29815)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -1440,12 +1440,11 @@
Object::null_array(),
2,
owner()->ic_data_array());
- if (FLAG_enable_type_checks) {
- Value* value = Bind(result);
- result = new AssertBooleanInstr(node->token_pos(), value);
- }
-
if (node->kind() == Token::kNE) {
+ if (FLAG_enable_type_checks) {
+ Value* value = Bind(result);
+ result = new AssertBooleanInstr(node->token_pos(), value);
+ }
Value* value = Bind(result);
result = new BooleanNegateInstr(value);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698