src/x64/lithium-x64.cc - Issue 57383004: Improve implementation of HSeqStringSetChar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 57383004: Improve implementation of HSeqStringSetChar. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Increase GVNFlags to 64bit. Add StringChars flag. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index 6262e7ede37719d537224d211569a945341ce68b..d90736a1673f3c35761ee81502455c9aec137035 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -1757,13 +1757,10 @@ LInstruction* LChunkBuilder::DoDateField(HDateField* instr) {

LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) {

- LOperand* string = UseRegister(instr->string());

- LOperand* index = UseRegister(instr->index());

- ASSERT(rcx.is_byte_register());

- LOperand* value = UseFixed(instr->value(), rcx);

- LSeqStringSetChar* result =

- new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value);

- return DefineSameAsFirst(result);

+ LOperand* string = UseRegisterAtStart(instr->string());

+ LOperand* index = UseRegisterOrConstantAtStart(instr->index());

+ LOperand* value = UseRegisterOrConstantAtStart(instr->value());

+ return new(zone()) LSeqStringSetChar(string, index, value);

}