Improve implementation of HSeqStringSetChar.

test/mjsunit/string-natives.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 11 matching lines @@
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --expose-gc --allow-natives-syntax
 
 function test() {
   var s1 = %NewString(26, true);
+  for (i = 0; i < 26; i++) %_OneByteSeqStringSetChar(s1, i, 65);
+  assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAA", s1);
+  %_OneByteSeqStringSetChar(s1, 25, 66);
+  assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAB", s1);
   for (i = 0; i < 26; i++) %_OneByteSeqStringSetChar(s1, i, i+65);
   assertEquals("ABCDEFGHIJKLMNOPQRSTUVWXYZ", s1);
   s1 = %TruncateString(s1, 13);
   assertEquals("ABCDEFGHIJKLM", s1);
 
   var s2 = %NewString(26, false);
+  for (i = 0; i < 26; i++) %_TwoByteSeqStringSetChar(s2, i, 65);
+  assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAA", s2);
+  %_TwoByteSeqStringSetChar(s2, 25, 66);
+  assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAB", s2);

[Yang, 2013/11/06 09:55:09]

Please also add a test that tests non-latin1 characters and where the character
being set is not a constant.

[Benedikt Meurer, 2013/11/06 10:06:36]

That's done below with s3 already.

   for (i = 0; i < 26; i++) %_TwoByteSeqStringSetChar(s2, i, i+65);
   assertEquals("ABCDEFGHIJKLMNOPQRSTUVWXYZ", s2);
-  s2 = %TruncateString(s1, 13);
+  s2 = %TruncateString(s2, 13);
   assertEquals("ABCDEFGHIJKLM", s2);
 
   var s3 = %NewString(26, false);
   for (i = 0; i < 26; i++) %_TwoByteSeqStringSetChar(s3, i, i+1000);
   for (i = 0; i < 26; i++) assertEquals(s3[i], String.fromCharCode(i+1000));
 
   var a = [];
   for (var i = 0; i < 1000; i++) {
     var s = %NewString(10000, i % 2 == 1);
     a.push(s);
@@ skipping 12 matching lines @@
     assertEquals(5000, a[i].length);
   }
 }
 
 
 test();
 test();
 %OptimizeFunctionOnNextCall(test);
 test();