Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 57383004: Improve implementation of HSeqStringSetChar. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Increase GVNFlags to 64bit. Add StringChars flag. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1739 matching lines...) Expand 10 before | Expand all | Expand 10 after
1750 1750
1751 1751
1752 LInstruction* LChunkBuilder::DoDateField(HDateField* instr) { 1752 LInstruction* LChunkBuilder::DoDateField(HDateField* instr) {
1753 LOperand* object = UseFixed(instr->value(), rax); 1753 LOperand* object = UseFixed(instr->value(), rax);
1754 LDateField* result = new(zone()) LDateField(object, instr->index()); 1754 LDateField* result = new(zone()) LDateField(object, instr->index());
1755 return MarkAsCall(DefineFixed(result, rax), instr, CAN_DEOPTIMIZE_EAGERLY); 1755 return MarkAsCall(DefineFixed(result, rax), instr, CAN_DEOPTIMIZE_EAGERLY);
1756 } 1756 }
1757 1757
1758 1758
1759 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) { 1759 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) {
1760 LOperand* string = UseRegister(instr->string()); 1760 LOperand* string = UseRegisterAtStart(instr->string());
1761 LOperand* index = UseRegister(instr->index()); 1761 LOperand* index = UseRegisterOrConstantAtStart(instr->index());
1762 ASSERT(rcx.is_byte_register()); 1762 LOperand* value = UseRegisterOrConstantAtStart(instr->value());
1763 LOperand* value = UseFixed(instr->value(), rcx); 1763 return new(zone()) LSeqStringSetChar(string, index, value);
1764 LSeqStringSetChar* result =
1765 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value);
1766 return DefineSameAsFirst(result);
1767 } 1764 }
1768 1765
1769 1766
1770 LInstruction* LChunkBuilder::DoBoundsCheck(HBoundsCheck* instr) { 1767 LInstruction* LChunkBuilder::DoBoundsCheck(HBoundsCheck* instr) {
1771 LOperand* value = UseRegisterOrConstantAtStart(instr->index()); 1768 LOperand* value = UseRegisterOrConstantAtStart(instr->index());
1772 LOperand* length = Use(instr->length()); 1769 LOperand* length = Use(instr->length());
1773 return AssignEnvironment(new(zone()) LBoundsCheck(value, length)); 1770 return AssignEnvironment(new(zone()) LBoundsCheck(value, length));
1774 } 1771 }
1775 1772
1776 1773
(...skipping 768 matching lines...) Expand 10 before | Expand all | Expand 10 after
2545 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2542 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2546 LOperand* object = UseRegister(instr->object()); 2543 LOperand* object = UseRegister(instr->object());
2547 LOperand* index = UseTempRegister(instr->index()); 2544 LOperand* index = UseTempRegister(instr->index());
2548 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2545 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2549 } 2546 }
2550 2547
2551 2548
2552 } } // namespace v8::internal 2549 } } // namespace v8::internal
2553 2550
2554 #endif // V8_TARGET_ARCH_X64 2551 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698