Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 57383002: Fix WM_POWERBROADCAST handling (Closed)

Created:
7 years, 1 month ago by yukawa
Modified:
7 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix WM_POWERBROADCAST handling This is a follow up CL of r185433, which mistook |message| for |wparam|. With this CL, base::PowerMonitor and base::PowerObserver become functional again on Windows. BUG=314477, 149059 TEST=manually done with a debugger (by disconnecting the power supply cable) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232900

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -59 lines) Patch
M base/power_monitor/power_monitor_device_source.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/power_monitor/power_monitor_device_source_win.cc View 3 chunks +36 lines, -56 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
yukawa
7 years, 1 month ago (2013-11-03 15:58:12 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/57383002/diff/50001/base/power_monitor/power_monitor_device_source_win.cc File base/power_monitor/power_monitor_device_source_win.cc (left): https://codereview.chromium.org/57383002/diff/50001/base/power_monitor/power_monitor_device_source_win.cc#oldcode106 base/power_monitor/power_monitor_device_source_win.cc:106: DWORD power_event = static_cast<DWORD>(message); Ah I see the ...
7 years, 1 month ago (2013-11-03 17:20:22 UTC) #2
yukawa
Hi Nico, Could you take an owner review? Basically there is no behavioral change except ...
7 years, 1 month ago (2013-11-03 18:21:20 UTC) #3
Nico
lgtm stamp
7 years, 1 month ago (2013-11-03 18:25:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/57383002/50001
7 years, 1 month ago (2013-11-03 19:04:29 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96988
7 years, 1 month ago (2013-11-03 21:10:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/57383002/50001
7 years, 1 month ago (2013-11-04 13:38:01 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97210
7 years, 1 month ago (2013-11-04 16:03:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/57383002/50001
7 years, 1 month ago (2013-11-05 00:27:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/57383002/50001
7 years, 1 month ago (2013-11-05 03:23:17 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 04:15:29 UTC) #11
Message was sent while issue was closed.
Change committed as 232900

Powered by Google App Engine
This is Rietveld 408576698