Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 573823002: [VS Addin] Fix several issues with debugging PPAPI plugins (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 3 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VS Addin] Fix several issues with debugging PPAPI plugins Add --ppapi-in-process so that the pepper plugins run in the renderer process. At some point in the past the default must have changed which was causing the VS addin code not to attach to the correct processes. Pass http://localhost:5103 to chrome process that we launch. It seems that passing just 'localhost:5103' no longer works. Don't use the x-nacl mimetype for PPAPI plugins. Instead use x-ppapi. The plugin is not permitted if x-nacl is used. Also, seems to be something that recently broke. Pass --no-first-run so that chrome doesn't try to log you in each time you start with a new data dir. TEST=test.sh R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1576

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Sam Clegg
6 years, 3 months ago (2014-09-15 19:07:42 UTC) #3
binji
lgtm
6 years, 3 months ago (2014-09-15 19:09:30 UTC) #4
Sam Clegg
6 years, 3 months ago (2014-09-15 19:18:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r1576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698