[Athena] Hide the windows which used to be in split view in ActivateSplitMode()

Hide windows which were visible in SplitView when new left/right windows are
specified.

BUG=409724
TEST=SplitViewcontrollerTest.SplitModeActivation

Committed: https://crrev.com/8de1135ae475d17cef2cd6e77ad93750420535fb
Cr-Commit-Position: refs/heads/master@{#295158}

[pkotwicz, 2014-09-15 20:56:56]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-09-15 20:57:43]

pkotwicz@chromium.org changed reviewers:
+ sadrul@chromium.org

[pkotwicz, 2014-09-15 20:57:43]

Sadrul, PTAL

[sadrul, 2014-09-15 21:01:21]

sadrul@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[sadrul, 2014-09-15 21:01:22]

+mfomitchev@

https://codereview.chromium.org/573803003/diff/20001/athena/wm/split_view_con...
File athena/wm/split_view_controller.cc (right):

https://codereview.chromium.org/573803003/diff/20001/athena/wm/split_view_con...
athena/wm/split_view_controller.cc:172: }
It's difficult to reason why this is here. OnAnimationCompleted() feels like a
more natural place for this (the explanation being that when the new left/right
windows have completed their animation to become visible, we no longer need the
old windows to remain visible, and so we hide them at that point).

[mfomitchev, 2014-09-15 22:18:35]

https://codereview.chromium.org/573803003/diff/20001/athena/wm/split_view_con...
File athena/wm/split_view_controller.cc (right):

https://codereview.chromium.org/573803003/diff/20001/athena/wm/split_view_con...
athena/wm/split_view_controller.cc:172: }
I agree. On a related note, I think it would be nice to move MoveToFront() and
Show() out of UpdateLayout and do those things in methods that perform state
changes. There's actually a bug with MoveToFront() right now - the drag from the
right is broken because the left window is always put on top of the right
window.

[pkotwicz, 2014-09-15 22:25:04]

Sadrul, can you please take another look?

[sadrul, 2014-09-16 15:04:07]

LGTM

[pkotwicz, 2014-09-16 15:14:48]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-09-16 15:14:49]

Oshima for OWNERS

[oshima, 2014-09-16 17:33:43]

lgtm

is the bug # correct?

can you also update the comment something like

Hide windows which were visible in SplitView when new left/right windows are
specified.

?

[pkotwicz, 2014-09-16 21:01:38]

The bug # is correct. The sole purpose of this CL is so that
https://codereview.chromium.org/546123002/ does not cause unit tests to break

[pkotwicz, 2014-09-16 21:01:41]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-09-16 21:02:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/573803003/60001

[commit-bot: I haz the power, 2014-09-16 22:22:00]

Committed patchset #3 (id:60001) as 1e587a1e3f85807e415de229642265c334af034f

[commit-bot: I haz the power, 2014-09-16 22:22:34]

Patchset 3 (id:??) landed as
https://crrev.com/8de1135ae475d17cef2cd6e77ad93750420535fb
Cr-Commit-Position: refs/heads/master@{#295158}