Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart

Issue 573803002: Issue 18926. Rename refactoring for labels. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart b/pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart
index e4e2f7b8d9ff364814e1bf0f3d2afb7030dcfead..2cb46747cda21cc09ffdd94754db3e06c82ef047 100644
--- a/pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart
@@ -8,9 +8,9 @@ import 'package:analysis_server/src/protocol.dart' show
RefactoringProblemSeverity;
import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
import 'package:analysis_server/src/services/refactoring/refactoring.dart';
-import '../../reflective_tests.dart';
import 'package:unittest/unittest.dart';
+import '../../reflective_tests.dart';
import 'abstract_refactoring.dart';
@@ -463,6 +463,72 @@ class NamingConventionsTest extends RefactoringTest {
expectedMessage: "Import prefix name must not start or end with a blank.");
}
+ void test_validateLabelName_OK() {
+ assertRefactoringStatusOK(validateLabelName("newName"));
+ }
+
+ void test_validateLabelName_OK_leadingDollar() {
+ assertRefactoringStatusOK(validateLabelName("\$newName"));
+ }
+
+ void test_validateLabelName_OK_leadingUnderscore() {
+ assertRefactoringStatusOK(validateLabelName("_newName"));
+ }
+
+ void test_validateLabelName_OK_middleUnderscore() {
+ assertRefactoringStatusOK(validateLabelName("new_name"));
+ }
+
+ void test_validateLabelName_doesNotStartWithLowerCase() {
+ assertRefactoringStatus(
+ validateLabelName("NewName"),
+ RefactoringProblemSeverity.WARNING,
+ expectedMessage: "Label name should start with a lowercase letter.");
+ }
+
+ void test_validateLabelName_empty() {
+ assertRefactoringStatus(
+ validateLabelName(""),
+ RefactoringProblemSeverity.FATAL,
+ expectedMessage: "Label name must not be empty.");
+ }
+
+ void test_validateLabelName_leadingBlanks() {
+ assertRefactoringStatus(
+ validateLabelName(" newName"),
+ RefactoringProblemSeverity.ERROR,
+ expectedMessage: "Label name must not start or end with a blank.");
+ }
+
+ void test_validateLabelName_notIdentifierMiddle() {
+ assertRefactoringStatus(
+ validateLabelName("new-Name"),
+ RefactoringProblemSeverity.ERROR,
+ expectedMessage: "Label name must not contain '-'.");
+ }
+
+ void test_validateLabelName_notIdentifierStart() {
+ assertRefactoringStatus(
+ validateLabelName("2newName"),
+ RefactoringProblemSeverity.ERROR,
+ expectedMessage:
+ "Label name must begin with a lowercase letter or underscore.");
+ }
+
+ void test_validateLabelName_null() {
+ assertRefactoringStatus(
+ validateLabelName(null),
+ RefactoringProblemSeverity.FATAL,
+ expectedMessage: "Label name must not be null.");
+ }
+
+ void test_validateLabelName_trailingBlanks() {
+ assertRefactoringStatus(
+ validateLabelName("newName "),
+ RefactoringProblemSeverity.ERROR,
+ expectedMessage: "Label name must not start or end with a blank.");
+ }
+
void test_validateLibraryName_OK_oneIdentifier() {
assertRefactoringStatusOK(validateLibraryName("name"));
}

Powered by Google App Engine
This is Rietveld 408576698