Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 573763002: Fix convexicator bug (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 3 months ago
Reviewers:
bsalomon, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix convexicator bug BUG=crbug.com/412640 Committed: https://skia.googlesource.com/skia/+/c506e3007e53fe7d1a77991de11fdb50a86fd532

Patch Set 1 #

Patch Set 2 : Second attempt #

Patch Set 3 : Fix left/right naming #

Patch Set 4 : Handle kInvalid_DirChange in switch statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -16 lines) Patch
M src/core/SkPath.cpp View 1 2 3 4 chunks +58 lines, -16 lines 0 comments Download
M tests/PathTest.cpp View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
robertphillips
6 years, 3 months ago (2014-09-15 16:19:37 UTC) #2
robertphillips
New Version
6 years, 3 months ago (2014-09-15 20:39:27 UTC) #3
bsalomon
lgtm
6 years, 3 months ago (2014-09-15 20:59:30 UTC) #4
caryclark
lgtm
6 years, 3 months ago (2014-09-16 16:06:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573763002/2
6 years, 3 months ago (2014-09-16 16:12:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1654)
6 years, 3 months ago (2014-09-16 16:17:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573763002/50001
6 years, 3 months ago (2014-09-16 16:36:18 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 16:43:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as c506e3007e53fe7d1a77991de11fdb50a86fd532

Powered by Google App Engine
This is Rietveld 408576698