Issue 573753002: Supervised user Apiary permission requests: Use correct API scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 573753002: Supervised user Apiary permission requests: Use correct API scope. (Closed)

Created:
6 years, 3 months ago by Marc Treib

Modified:
6 years, 3 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Supervised user Apiary permission requests: Use correct API scope. Previously, a scope passed in explicitly via the command line was not applied consistently. BUG=372381 Committed: https://crrev.com/fb5714953e4710bf25aeab42a1a59d663a8971ce Cr-Commit-Position: refs/heads/master@{#294855}

Patch Set 1 #

Patch Set 2 : naming #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	chrome/browser/supervised_user/permission_request_creator_apiary.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/supervised_user/permission_request_creator_apiary.cc	View	1	2 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573753002/20001

6 years, 3 months ago (2014-09-15 16:19:37 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 565266b2acc0e633fc76cc312a20b9be0118850b

6 years, 3 months ago (2014-09-15 18:44:39 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-15 19:03:34 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/fb5714953e4710bf25aeab42a1a59d663a8971ce
Cr-Commit-Position: refs/heads/master@{#294855}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages