Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 573743002: Roll ASan/Win to r217738 (Closed)

Created:
6 years, 3 months ago by Timur Iskhodzhanov
Modified:
6 years, 3 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll ASan/Win to r217738 Also update the name of the asan dynamic runtime thunk .lib since it was changed in LLVM r217673. After this change, component ASan build should be able to report NULL derefs and other AVs the same way as the static build does. BUG=345874 Committed: https://crrev.com/1d8adb2349f07f2595319f4ef7389001d3e9fd8f Cr-Commit-Position: refs/heads/master@{#294857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Timur Iskhodzhanov
rnk@ -- please review inferno@ -- just FYI in case anything breaks on the LKGR ...
6 years, 3 months ago (2014-09-15 14:14:39 UTC) #2
Reid Kleckner
lgtm
6 years, 3 months ago (2014-09-15 15:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573743002/1
6 years, 3 months ago (2014-09-15 16:28:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 98c3f83f63bea1daa85b7fb66028f74b626e5726
6 years, 3 months ago (2014-09-15 18:49:30 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 19:03:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d8adb2349f07f2595319f4ef7389001d3e9fd8f
Cr-Commit-Position: refs/heads/master@{#294857}

Powered by Google App Engine
This is Rietveld 408576698