Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 573733004: Roll cacheinvalidation DEPS to r341 (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
Reviewers:
Nicolas Zea, Colin Meek
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-navigation-controller
Project:
chromium
Visibility:
Public.

Description

Roll cacheinvalidation DEPS to r341 This removes the last known dependency on guava_javalib. Full list of changes: r340 Removing guava dependency for the invalidation client (part of an effort to reduce method count in Android applications) r341 Fixing package name in AndroidListenerManifest.xml and ordering factory methods by corresponding proto field in AndroidService.java BUG=412673 TBR=zea@chromium.org Committed: https://crrev.com/b7d5c878ba7ee66e929f299c92fd5393022b5586 Cr-Commit-Position: refs/heads/master@{#295113}

Patch Set 1 #

Patch Set 2 : roll to 341 and update readme #

Patch Set 3 : Rebased #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java View 3 chunks +2 lines, -3 lines 2 comments Download
M third_party/cacheinvalidation/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
nyquist
meek: PTAL zea: PTAL OWNERS
6 years, 3 months ago (2014-09-15 22:42:35 UTC) #2
Colin Meek
On 2014/09/15 22:42:35, nyquist wrote: > meek: PTAL > zea: PTAL OWNERS LGTM
6 years, 3 months ago (2014-09-16 17:54:18 UTC) #3
Colin Meek
https://codereview.chromium.org/573733004/diff/40001/sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java File sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java (right): https://codereview.chromium.org/573733004/diff/40001/sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java#newcode114 sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java:114: if (syncTypes == null) throw new NullPointerException("syncTypes is null."); ...
6 years, 3 months ago (2014-09-16 17:54:35 UTC) #4
Colin Meek
6 years, 3 months ago (2014-09-16 17:54:40 UTC) #5
nyquist
moving zea@ to TBR https://codereview.chromium.org/573733004/diff/40001/sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java File sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java (right): https://codereview.chromium.org/573733004/diff/40001/sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java#newcode114 sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java:114: if (syncTypes == null) throw ...
6 years, 3 months ago (2014-09-16 17:59:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573733004/40001
6 years, 3 months ago (2014-09-16 18:00:32 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as e02cfc0f8b4fc40420f64d5ee14b04026cdd5f31
6 years, 3 months ago (2014-09-16 18:47:57 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 18:49:47 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b7d5c878ba7ee66e929f299c92fd5393022b5586
Cr-Commit-Position: refs/heads/master@{#295113}

Powered by Google App Engine
This is Rietveld 408576698