Issue 57373003: omnibox: DeriveFontList() call should use Font::BOLD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57373003: omnibox: DeriveFontList() call should use Font::BOLD. (Closed)

Created:
7 years, 1 month ago by tfarina

Modified:
7 years, 1 month ago

Reviewers:
msw, Peter Kasting

CC:
chromium-reviews, tfarina, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

omnibox: DeriveFontList() call should use Font::BOLD. The use of gfx::TextStyle enum is deprecated, thus we should use the constant from gfx::Font::FontStyle. BUG=None TEST=None R=pkasting@chromium.org,msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232942

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	chrome/browser/ui/views/omnibox/omnibox_result_view.cc	View		2 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 6 (0 generated)

Peter Kasting

LGTM, remember to always say what each of multiple reviewers are doing (I assume in ...

7 years, 1 month ago (2013-11-04 22:09:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57373003/1

7 years, 1 month ago (2013-11-05 00:26:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57373003/1

7 years, 1 month ago (2013-11-05 03:22:36 UTC) #5

Message was sent while issue was closed.

Change committed as 232942