Issue 57373002: DevTools: Add support for adding folders to workspace with drag and drop (renderer part)

Issue 57373002: DevTools: Add support for adding folders to workspace with drag and drop (renderer part) (Closed)

Created:
7 years, 1 month ago by vsevik

Modified:
7 years, 1 month ago

Reviewers:
kinuko, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Add support for adding folders to workspace with drag and drop (renderer part) browser part: https://chromiumcodereview.appspot.com/57073004/ BUG=314476 R=pfeldman, kinuko Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161423

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -0 lines)			Patch
M	Source/core/inspector/InspectorFrontendHost.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.cpp	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/InspectorFrontendHostStub.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/SourcesPanel.js	View	1 chunk	+41 lines, -0 lines	2 comments	Download
M	Source/devtools/front_end/externs.js	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/sourcesView.css	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

Pavel, could you please review this? Kinuko, could you please review file system usage?

7 years, 1 month ago (2013-11-03 15:44:15 UTC) #1

pfeldman

https://codereview.chromium.org/57373002/diff/1/Source/devtools/front_end/SourcesPanel.js File Source/devtools/front_end/SourcesPanel.js (right): https://codereview.chromium.org/57373002/diff/1/Source/devtools/front_end/SourcesPanel.js#newcode1629 Source/devtools/front_end/SourcesPanel.js:1629: InspectorFrontendHost.upgradeDraggedFileSystemPermissions(entry.filesystem); What's wrong with sendMessageToEmbedder(["upgradeDraggedFileSystemPermissions", entry.filesystem.root.toURL()]) ?

7 years, 1 month ago (2013-11-05 06:14:49 UTC) #2

kinuko

filesystem API usage lgtm. https://codereview.chromium.org/57373002/diff/1/Source/devtools/front_end/SourcesPanel.js File Source/devtools/front_end/SourcesPanel.js (right): https://codereview.chromium.org/57373002/diff/1/Source/devtools/front_end/SourcesPanel.js#newcode1629 Source/devtools/front_end/SourcesPanel.js:1629: InspectorFrontendHost.upgradeDraggedFileSystemPermissions(entry.filesystem); On 2013/11/05 06:14:49, pfeldman ...

7 years, 1 month ago (2013-11-05 07:46:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/57373002/1

7 years, 1 month ago (2013-11-06 04:56:45 UTC) #5

Message was sent while issue was closed.

Change committed as 161423

Expand Messages | Collapse Messages